csh: Define ECHO and COMMAND_SEP
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ansible-collections#204 Signed-off-by: Abhijeet Kasurde <[email protected]>
|
Before fix - |
saito-hideki
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
@Akasurde Thank you for the PR!
LGTM, and this fix is working without any issue on my end.
bcoca
approved these changes
Jun 9, 2021
Akasurde
added
the
gate
|
@saito-hideki @bcoca Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes: #204
Signed-off-by: Abhijeet Kasurde [email protected]
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/204_csh_shell.yml
plugins/shell/csh.py