Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorized_key: Add support for additional key types #189

Merged
merged 1 commit into from
May 27, 2021

Conversation

Akasurde
Copy link
Member

SUMMARY

Fixes: #134

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/134_authorized_key.yml
plugins/modules/authorized_key.py

@Akasurde
Copy link
Member Author

cc @quidame @saito-hideki @justjais Could you please review this? Thanks,

Copy link
Contributor

@quidame quidame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akasurde thanks for improving this module !

changelogs/fragments/134_authorized_key.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@saito-hideki saito-hideki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akasurde Thank you for the PR! I have tested VALID_SSH2_KEY_TYPES and your changes are working fine on my testing environment. :)

@quidame
Copy link
Contributor

quidame commented May 26, 2021

the CI tests error doesn't seem to be related to this PR

@Akasurde
Copy link
Member Author

/recheck

@Akasurde
Copy link
Member Author

Closing and re-opening for CI trigger.

@Akasurde Akasurde closed this May 27, 2021
@Akasurde Akasurde reopened this May 27, 2021
@Akasurde Akasurde added the gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate") label May 27, 2021
@ansible-zuul ansible-zuul bot merged commit eaf3d66 into ansible-collections:main May 27, 2021
@Akasurde Akasurde deleted the i134 branch May 27, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate")
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not all openssh public key authentication types are supported
3 participants