simplify value conversion by removing ast.literal_eval #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Ruchip16
reviewed
Oct 29, 2024
| return ast.literal_eval(value) | ||
| except Exception: | ||
| return str(value) | ||
| if value is not None: |
There was a problem hiding this comment.
@AAYUSH2091 we generally put try and exception block to handle corner cases so i dont think removing this would be a good option here, so you might wanna revert it back if thats not something blocking you but we cant just refactor the code this way, this might open other potential problems/errors for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Simplifies the value handling logic in network common utils by removing the complex ast.literal_eval approach in favor of direct string conversion.
ISSUE TYPE
COMPONENT NAME
network.common.utils