Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segregate filter plugins #578

Merged
merged 38 commits into from
Aug 22, 2023
Merged

Segregate filter plugins #578

merged 38 commits into from
Aug 22, 2023

Conversation

KB-perByte
Copy link
Collaborator

@KB-perByte KB-perByte commented Aug 4, 2023 •
edited
Loading

SUMMARY

Remove network.py and add filter plugins individually
Add examples and documentation.
Impacts -

 comp_type5
 hash_salt
 parse_cli
 parse_cli_textfsm
 parse_xml
 type5_pw
 vlan_parser
 vlan_expander
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vlan_expander

ADDITIONAL INFORMATION
TODO
  • comp_type5
  • hash_salt
  • parse_cli
  • parse_cli_textfsm
  • parse_xml
  • type5_pw
  • vlan_parser
  • vlan_expander
  • add separate documentation
  • add examples
  • preserve authors
  • correct version added

@KB-perByte KB-perByte added enhancement Is a enhancement skip-changelog A trivial PR not requiring a change log for users and removed enhancement Is a enhancement labels Aug 4, 2023
@KB-perByte KB-perByte changed the title [vlan_expander] filter plugin Segregate filter plugins Aug 8, 2023
@KB-perByte KB-perByte changed the title Segregate filter plugins WIP Segregate filter plugins Aug 8, 2023
KB-perByte and others added 14 commits August 8, 2023 18:19
@KB-perByte KB-perByte added skip-changelog A trivial PR not requiring a change log for users and removed skip-changelog A trivial PR not requiring a change log for users labels Aug 9, 2023
Qalthos
Qalthos requested changes Aug 9, 2023
View reviewed changes
plugins/filter/parse_cli.py Outdated Show resolved Hide resolved
@Qalthos Qalthos removed the skip-changelog A trivial PR not requiring a change log for users label Aug 16, 2023
Qalthos
Qalthos approved these changes Aug 16, 2023
View reviewed changes
tests/unit/plugins/filter/test_vlan_parser.py Outdated Show resolved Hide resolved
@KB-perByte KB-perByte mentioned this pull request Aug 17, 2023
Closed
@KB-perByte KB-perByte added the enhancement Is a enhancement label Aug 22, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/154a1236d5c645ca937c893762e79702

❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 14m 11s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 19m 22s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 08m 23s
❌ ansible-test-network-integration-junos-vsrx-netconf-python39 RETRY_LIMIT in 6m 51s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 13m 34s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 17m 46s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 17m 01s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python39 RETRY_LIMIT in 4m 16s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 16m 19s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 SUCCESS in 18m 13s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 FAILURE in 13m 57s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 RETRY_LIMIT in 6m 37s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 35s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 30m 10s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 36m 09s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 28m 24s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-python39 RETRY_LIMIT in 8m 15s (non-voting)
❌ ansible-test-network-integration-eos-httpapi-python39 RETRY_LIMIT in 8m 26s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-libssh-python39 RETRY_LIMIT in 9m 38s (non-voting)
❌ ansible-ee-integration-ios-latest FAILURE in 13m 19s (non-voting)
❌ ansible-ee-integration-ios-stable-2.9 FAILURE in 18m 32s (non-voting)
❌ ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 12s (non-voting)
❌ ansible-ee-integration-ios-stable-2.12 FAILURE in 12m 46s (non-voting)
❌ ansible-ee-integration-ios-libssh-latest FAILURE in 1h 33m 33s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 45s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 15m 39s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 12m 53s (non-voting)
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0006302628 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0006302629 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0006302630 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0006302631 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0006302632 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0006302633 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0006302634 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0006302635 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0006302636 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0006302637 failed in 0s
✔️ build-ansible-collection SUCCESS in 14m 10s
❌ ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 RETRY_LIMIT in 8m 08s
✔️ ansible-tox-linters SUCCESS in 10m 32s
✔️ ansible-galaxy-importer SUCCESS in 4m 22s

@KB-perByte KB-perByte merged commit a07256b into ansible-collections:main Aug 22, 2023
50 of 51 checks passed
@KB-perByte KB-perByte deleted the vlan_expander branch August 22, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qalthos Qalthos Qalthos approved these changes

Assignees
No one assigned
Labels
enhancement Is a enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KB-perByte @Qalthos