Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make setting ansible_network_os optional #329

Merged
merged 7 commits into from
Oct 5, 2021
Merged

Make setting ansible_network_os optional #329

merged 7 commits into from
Oct 5, 2021

Conversation

justjais
Copy link
Member

@justjais justjais commented Sep 20, 2021 •
edited by Qalthos
Loading

SUMMARY

Make setting ansible_network_os optional

Depends-on: ansible/ansible-zuul-jobs#1139

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

httpapi

ADDITIONAL INFORMATION

@justjais justjais mentioned this pull request Sep 20, 2021
Open
@justjais
Copy link
Member Author

recheck

1 similar comment
@justjais
Copy link
Member Author

recheck

ganeshrn
ganeshrn reviewed Sep 22, 2021
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar change can be added in the network_cli and netconf connection plugins

@justjais
Copy link
Member Author

@ganeshrn yea, but at this point both netconf and network_cli are specific to network, imo we can start with httpapi and if in future there's need/community demand we can apply the changes to netconf and network_cli as well.

@Qalthos
Copy link
Collaborator

Qalthos commented Sep 23, 2021

recheck

1 similar comment
@Qalthos
Copy link
Collaborator

Qalthos commented Sep 23, 2021

recheck

@Qalthos
Copy link
Collaborator

Qalthos commented Sep 23, 2021

recheck

1 similar comment
@Qalthos
Copy link
Collaborator

Qalthos commented Sep 24, 2021

recheck

@Qalthos Qalthos added the mergeit Gate PR in Zuul CI label Sep 24, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Qalthos Qalthos removed the mergeit Gate PR in Zuul CI label Sep 24, 2021
@justjais
Copy link
Member Author

recheck

@Qalthos Qalthos added the mergeit Gate PR in Zuul CI label Sep 28, 2021
@ansible-zuul ansible-zuul bot removed the mergeit Gate PR in Zuul CI label Sep 28, 2021
@justjais
Copy link
Member Author

recheck

1 similar comment
@justjais
Copy link
Member Author

recheck

@justjais justjais added mergeit Gate PR in Zuul CI and removed mergeit Gate PR in Zuul CI labels Sep 30, 2021
@justjais justjais added mergeit Gate PR in Zuul CI and removed mergeit Gate PR in Zuul CI labels Oct 1, 2021
@ansible-zuul ansible-zuul bot merged commit 71900b5 into ansible-collections:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshrn ganeshrn ganeshrn left review comments

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@Qalthos Qalthos Qalthos approved these changes

Assignees
No one assigned
Labels
mergeit Gate PR in Zuul CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justjais @Qalthos @ganeshrn