-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to record and replay module for testing purpose #998
add ability to record and replay module for testing purpose #998
Conversation
Use the ``placebo`` (https://pypi.org/project/placebo/) to record the API interaction. This allow us to replay later a previous interaction offline and cover some cases that are hard to reproduce in a CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting this off, generally LGTM but a couple of minor comments
tests/integration/targets/module_utils_botocore_recorder/tasks/main.yml
Outdated
Show resolved
Hide resolved
2375cda
to
73b3b61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to see a follow up which includes some documentation around how to re-record.
We should also keep an eye on the size of any recordings. Depending on how frequently the recordings are updated, this could explode the size of the repo without a clean way to shrink it back down.
@goneri I've not backported this to stable-4 since I don't think we'll have any specific needs for it, but I wouldn't block a backport if someone requested one. |
Depends-On: ansible/ansible-zuul-jobs#1619
Use lib
placebo
(https://pypi.org/project/placebo/) to record the APIinteraction. This allow us to replay later a previous interaction offline
and cover some cases that are hard to reproduce in a CI.