[PR #983/d80ab5b2 backport][stable-3] Fix deprecation warning on instance_type #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Fix deprecation warning on instance_type SUMMARY Specifying instance_type should not be required unless count or exact_count are specified. If the user is just trying to start/stop instances then we don't need to ask for size. Fixes #980 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Brian Scholer <None> (cherry picked from commit d80ab5b)
ansibullbot
added
bug
|
recheck |
|
recheck |
|
recheck |
|
Since 3.x will soon be dead, I don't think it's worth poking too hard at the integration tests here. Closing the backport |
tremble
deleted the
patchback/backports/stable-3/d80ab5b2edacefb558ba74404a98d92590ecdcba/pr-983
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #983 as merged into main (d80ab5b).
SUMMARY
Specifying
instance_typeshould not be required unlesscountorexact_countare specified.If the user is just trying to start/stop instances then we don't need to ask for size.
Fixes #980
ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION