Rename ec2_url #992
Merged
Rename ec2_url #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
tremble
force-pushed
the
params/ec2_url
branch
2 times, most recently
from
df69b2b to
83e5bf5
Compare
alinabuzachis
approved these changes
Sep 6, 2022
tremble
force-pushed
the
params/ec2_url
branch
from
83e5bf5 to
76bba8c
Compare
tremble
added
the
do_not_backport
This was referenced Sep 6, 2022
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Sep 6, 2022
Changelog Rename ec2_url to endpoint_url SUMMARY In ansible-collections/amazon.aws#992 ec2_url was renamed to endpoint_url, with ec2_url remaining as an alias. This fragment is to improve visibility for a cross-collection change. ISSUE TYPE Docs Pull Request COMPONENT NAME changelogs/fragments/ ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
merge s3_url parameter into endpoint_url SUMMARY (related to #992) Merges the s3_url parameter into endpoint_url. This makes the modules more consistent with the rest of the collection. Adds rgw as an alias to the ceph parameter in s3_bucket, and renames rgw to ceph (keeping an alias) in s3_object. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/s3_bucket.py plugins/modules/s3_object.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
This was referenced Oct 4, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
ec2_urlparameter is actually the aws endpoint URL, the name is a side effect of EC2 being the original modules. Rename it for consistency.ISSUE TYPE
COMPONENT NAME
plugins/doc_fragments/aws.py
plugins/module_utils/botocore.py
plugins/module_utils/modules.py
ADDITIONAL INFORMATION