[PR #971/9e7ae6cf backport][stable-4] ec2_security_group: Set rules->group_name's datatype as raw #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ec2_security_group: Set rules->group_name's datatype as raw Signed-off-by: GomathiselviS [email protected] SUMMARY rules-> group_name can accept values of type list and str. ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_security_group.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> (cherry picked from commit 9e7ae6c)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
docs
module
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/9e7ae6cf978004d6d407571d3d386a965af079fd/pr-971
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
) New Modules: AWS Network Firewall - rule groups Sorta-Depends-On: ansible-collections#974 SUMMARY Two new modules for AWS Network Firewall rule groups. This first iteration will only support stateful rule groups. networkfirewall_rule_group.py networkfirewall_rule_group_info.py ToDo: Initial modules Return Value documentation Integration Tests CI Permissions ISSUE TYPE New Module Pull Request COMPONENT NAME plugins/module_utils/networkfirewall.py plugins/modules/networkfirewall_rule_group.py plugins/modules/networkfirewall_rule_group_info.py ADDITIONAL INFORMATION Note: It's a deliberate choice not to support creation of stateless rules initially. I want to get some of the initial framework in place so that the Policy and Firewall pieces can be built out while waiting on reviews. Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
) New Modules: AWS Network Firewall - rule groups Sorta-Depends-On: ansible-collections#974 SUMMARY Two new modules for AWS Network Firewall rule groups. This first iteration will only support stateful rule groups. networkfirewall_rule_group.py networkfirewall_rule_group_info.py ToDo: Initial modules Return Value documentation Integration Tests CI Permissions ISSUE TYPE New Module Pull Request COMPONENT NAME plugins/module_utils/networkfirewall.py plugins/modules/networkfirewall_rule_group.py plugins/modules/networkfirewall_rule_group_info.py ADDITIONAL INFORMATION Note: It's a deliberate choice not to support creation of stateless rules initially. I want to get some of the initial framework in place so that the Policy and Firewall pieces can be built out while waiting on reviews. Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
) New Modules: AWS Network Firewall - rule groups Sorta-Depends-On: ansible-collections#974 SUMMARY Two new modules for AWS Network Firewall rule groups. This first iteration will only support stateful rule groups. networkfirewall_rule_group.py networkfirewall_rule_group_info.py ToDo: Initial modules Return Value documentation Integration Tests CI Permissions ISSUE TYPE New Module Pull Request COMPONENT NAME plugins/module_utils/networkfirewall.py plugins/modules/networkfirewall_rule_group.py plugins/modules/networkfirewall_rule_group_info.py ADDITIONAL INFORMATION Note: It's a deliberate choice not to support creation of stateless rules initially. I want to get some of the initial framework in place so that the Policy and Firewall pieces can be built out while waiting on reviews. Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #971 as merged into main (9e7ae6c).
Signed-off-by: GomathiselviS [email protected]
SUMMARY
rules-> group_name can accept values of type list and str.
ISSUE TYPE
COMPONENT NAME
ec2_security_group.py
ADDITIONAL INFORMATION