Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #953 backport][stable-4] Minor linting fixups - 2022-08-04 #965

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Aug 11, 2022

SUMMARY

Minor linting fixups

  • docs
  • unused variables
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
plugins/module_utils/acm.py
plugins/module_utils/botocore.py
plugins/module_utils/cloud.py
plugins/module_utils/iam.py
plugins/module_utils/modules.py
plugins/module_utils/rds.py

ADDITIONAL INFORMATION

Original PR
Reviewed-by: Jill R
Reviewed-by: Gonéri Le Bouder

##### SUMMARY

Minor linting fixups

- docs
- unused variables

##### ISSUE TYPE

Feature Pull Request

##### COMPONENT NAME

plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
plugins/module_utils/acm.py
plugins/module_utils/botocore.py
plugins/module_utils/cloud.py
plugins/module_utils/iam.py
plugins/module_utils/modules.py
plugins/module_utils/rds.py

##### ADDITIONAL INFORMATION

Original PR
Reviewed-by: Jill R
Reviewed-by: Gonéri Le Bouder
@tremble tremble changed the title Minor linting fixups (#953) [PR #953 backport][stable-4] Minor linting fixups Aug 11, 2022
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module_utils module_utils needs_triage plugins plugin (any type) labels Aug 11, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

@tremble tremble changed the title [PR #953 backport][stable-4] Minor linting fixups [PR #953 backport][stable-4] Minor linting fixups - 2022-08-04 Aug 11, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 5m 14s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 7m 57s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 16s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 58s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 24s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 48s
✔️ ansible-test-splitter SUCCESS in 3m 10s
✔️ integration-amazon.aws-1 SUCCESS in 11m 44s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 5m 15s
✔️ integration-community.aws-2 SUCCESS in 42m 14s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 13s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 17, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 4m 55s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 04s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 58s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 33s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 16s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 58s
✔️ ansible-test-splitter SUCCESS in 2m 30s
✔️ integration-amazon.aws-1 SUCCESS in 14m 21s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 5m 32s
✔️ integration-community.aws-2 SUCCESS in 47m 43s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 12s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c5d9935 into ansible-collections:stable-4 Aug 17, 2022
@tremble tremble deleted the backport/stable-4/953 branch September 9, 2022 08:49
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Fix linting issues reported by validate-modules in plugins

SUMMARY
See ansible-collections/news-for-maintainers#9.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
various

Reviewed-by: Jill R <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module_utils module_utils plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants