-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #953 backport][stable-4] Minor linting fixups - 2022-08-04 #965
Merged
softwarefactory-project-zuul
merged 2 commits into
ansible-collections:stable-4
from
tremble:backport/stable-4/953
Aug 17, 2022
Merged
[PR #953 backport][stable-4] Minor linting fixups - 2022-08-04 #965
softwarefactory-project-zuul
merged 2 commits into
ansible-collections:stable-4
from
tremble:backport/stable-4/953
Aug 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
##### SUMMARY Minor linting fixups - docs - unused variables ##### ISSUE TYPE Feature Pull Request ##### COMPONENT NAME plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py plugins/lookup/aws_account_attribute.py plugins/lookup/aws_secret.py plugins/lookup/aws_ssm.py plugins/module_utils/acm.py plugins/module_utils/botocore.py plugins/module_utils/cloud.py plugins/module_utils/iam.py plugins/module_utils/modules.py plugins/module_utils/rds.py ##### ADDITIONAL INFORMATION Original PR Reviewed-by: Jill R Reviewed-by: Gonéri Le Bouder
tremble
changed the title
Minor linting fixups (#953)
[PR #953 backport][stable-4] Minor linting fixups
Aug 11, 2022
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
module_utils
module_utils
needs_triage
plugins
plugin (any type)
labels
Aug 11, 2022
This comment was marked as outdated.
This comment was marked as outdated.
tremble
changed the title
[PR #953 backport][stable-4] Minor linting fixups
[PR #953 backport][stable-4] Minor linting fixups - 2022-08-04
Aug 11, 2022
This comment was marked as outdated.
This comment was marked as outdated.
alinabuzachis
approved these changes
Aug 16, 2022
softwarefactory-project-zuul
bot
merged commit Aug 17, 2022
c5d9935
into
ansible-collections:stable-4
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Fix linting issues reported by validate-modules in plugins SUMMARY See ansible-collections/news-for-maintainers#9. ISSUE TYPE Bugfix Pull Request COMPONENT NAME various Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
mergeit
Merge the PR (SoftwareFactory)
module_utils
module_utils
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Minor linting fixups
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
plugins/module_utils/acm.py
plugins/module_utils/botocore.py
plugins/module_utils/cloud.py
plugins/module_utils/iam.py
plugins/module_utils/modules.py
plugins/module_utils/rds.py
ADDITIONAL INFORMATION
Original PR
Reviewed-by: Jill R
Reviewed-by: Gonéri Le Bouder