Fix NoneType errors with elb_classic_lb #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
changed the title
ansibullbot
added
WIP
tremble
changed the title
|
@andrew-pickin-epi if you're able to test this PR fixes the issue you've reported that would be appreciated. |
tremble
added
backport-2
|
Tested with and without |
alinabuzachis
approved these changes
Jul 6, 2022
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #918 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Fix NoneType errors with elb_classic_lb SUMMARY fixes: #589 fixes: #914 Fixes two NoneType related bugs when creating new ELBs. (includes extra tests this time to trigger the bugs) ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/elb_classic_lb.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 8ce9c19)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #919 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Fix NoneType errors with elb_classic_lb SUMMARY fixes: #589 fixes: #914 Fixes two NoneType related bugs when creating new ELBs. (includes extra tests this time to trigger the bugs) ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/elb_classic_lb.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 8ce9c19)
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #920 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Fix NoneType errors with elb_classic_lb SUMMARY fixes: #589 fixes: #914 Fixes two NoneType related bugs when creating new ELBs. (includes extra tests this time to trigger the bugs) ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/elb_classic_lb.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 8ce9c19)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
[PR #915/8ce9c198 backport][stable-3] Fix NoneType errors with elb_classic_lb This is a backport of PR #915 as merged into main (8ce9c19). SUMMARY fixes: #589 fixes: #914 Fixes two NoneType related bugs when creating new ELBs. (includes extra tests this time to trigger the bugs) ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/elb_classic_lb.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
[PR #915/8ce9c198 backport][stable-2] Fix NoneType errors with elb_classic_lb This is a backport of PR #915 as merged into main (8ce9c19). SUMMARY fixes: #589 fixes: #914 Fixes two NoneType related bugs when creating new ELBs. (includes extra tests this time to trigger the bugs) ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/elb_classic_lb.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
[PR #915/8ce9c198 backport][stable-4] Fix NoneType errors with elb_classic_lb This is a backport of PR #915 as merged into main (8ce9c19). SUMMARY fixes: #589 fixes: #914 Fixes two NoneType related bugs when creating new ELBs. (includes extra tests this time to trigger the bugs) ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/elb_classic_lb.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
1 task
1 task
goneri
pushed a commit
that referenced
this pull request
Sep 20, 2022
elb_application_lb/elb_network_lb - Add documentation for TargetGroupName SUMMARY fixes: #915 elb_application_lb and elb_network_lb have a poorly documented feature, that you can use TargetGroupName instead of TargetGroupArn. While this is shown in the examples, it's in the options documentation. While undocumented the feature's been there since at release 1.0.0 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/elb_application_lb.py plugins/modules/elb_network_lb.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9fe9fc4
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Sep 20, 2022
elb_application_lb/elb_network_lb - Add documentation for TargetGroupName SUMMARY fixes: ansible-collections#915 elb_application_lb and elb_network_lb have a poorly documented feature, that you can use TargetGroupName instead of TargetGroupArn. While this is shown in the examples, it's in the options documentation. While undocumented the feature's been there since at release 1.0.0 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/elb_application_lb.py plugins/modules/elb_network_lb.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9fe9fc4
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
elb_application_lb/elb_network_lb - Add documentation for TargetGroupName SUMMARY fixes: ansible-collections#915 elb_application_lb and elb_network_lb have a poorly documented feature, that you can use TargetGroupName instead of TargetGroupArn. While this is shown in the examples, it's in the options documentation. While undocumented the feature's been there since at release 1.0.0 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/elb_application_lb.py plugins/modules/elb_network_lb.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
elb_application_lb/elb_network_lb - Add documentation for TargetGroupName SUMMARY fixes: ansible-collections#915 elb_application_lb and elb_network_lb have a poorly documented feature, that you can use TargetGroupName instead of TargetGroupArn. While this is shown in the examples, it's in the options documentation. While undocumented the feature's been there since at release 1.0.0 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/elb_application_lb.py plugins/modules/elb_network_lb.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
elb_application_lb/elb_network_lb - Add documentation for TargetGroupName SUMMARY fixes: ansible-collections#915 elb_application_lb and elb_network_lb have a poorly documented feature, that you can use TargetGroupName instead of TargetGroupArn. While this is shown in the examples, it's in the options documentation. While undocumented the feature's been there since at release 1.0.0 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/elb_application_lb.py plugins/modules/elb_network_lb.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes: #589
fixes: #914
Fixes two NoneType related bugs when creating new ELBs.
(includes extra tests this time to trigger the bugs)
ISSUE TYPE
COMPONENT NAME
plugins/modules/elb_classic_lb.py
ADDITIONAL INFORMATION