-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop deprecated (CamelCase) aliases #913
Merged
softwarefactory-project-zuul
merged 2 commits into
ansible-collections:main
from
tremble:deprecations/5.0.0/CamelCase
Jul 5, 2022
Merged
Drop deprecated (CamelCase) aliases #913
softwarefactory-project-zuul
merged 2 commits into
ansible-collections:main
from
tremble:deprecations/5.0.0/CamelCase
Jul 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
changed the title
Drop deprecated (CamelCase) aliases
[WIP] Drop deprecated (CamelCase) aliases
Jul 5, 2022
ansibullbot
added
WIP
Work in progress
feature
This issue/PR relates to a feature request
module
module
labels
Jul 5, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
labels
Jul 5, 2022
tremble
force-pushed
the
deprecations/5.0.0/CamelCase
branch
from
July 5, 2022 13:14
aea355b
to
917c635
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
deprecations/5.0.0/CamelCase
branch
from
July 5, 2022 13:57
917c635
to
0451b4d
Compare
ansibullbot
added
tests
tests
and removed
owner_pr
PR created by owner/maintainer
labels
Jul 5, 2022
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
deprecations/5.0.0/CamelCase
branch
from
July 5, 2022 14:24
0451b4d
to
2be138d
Compare
tremble
changed the title
[WIP] Drop deprecated (CamelCase) aliases
Drop deprecated (CamelCase) aliases
Jul 5, 2022
alinabuzachis
approved these changes
Jul 5, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Update ec2_vpc_dhcp_option_info to remove deprecated alias SUMMARY With #913 the CamelCase aliases in ec2_vpc_dhcp_option_info were dropped. Updates the example to use the snake case version ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/ec2_vpc_dhcp_option_info.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…e-collections#913) Add deregistration_connection_termination to elb_target_group SUMMARY Adding support for the deregistration_connection_termination param in the elb_target_group module. Along with this I've enabled and fixed up the integration tests. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION The API param is deregistration_delay.connection_termination.enabled https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.describe_target_group_attributes Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…e-collections#913) Add deregistration_connection_termination to elb_target_group SUMMARY Adding support for the deregistration_connection_termination param in the elb_target_group module. Along with this I've enabled and fixed up the integration tests. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION The API param is deregistration_delay.connection_termination.enabled https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.describe_target_group_attributes Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…e-collections#913) Add deregistration_connection_termination to elb_target_group SUMMARY Adding support for the deregistration_connection_termination param in the elb_target_group module. Along with this I've enabled and fixed up the integration tests. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION The API param is deregistration_delay.connection_termination.enabled https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.describe_target_group_attributes Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
mergeit
Merge the PR (SoftwareFactory)
module
module
needs_triage
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Complete the deprecation cycle on CamelCased aliases
ISSUE TYPE
COMPONENT NAME
ec2_ami
ec2_vpc_dhcp_option_info
ADDITIONAL INFORMATION