Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated (CamelCase) aliases #913

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 5, 2022

SUMMARY

Complete the deprecation cycle on CamelCased aliases

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_ami
ec2_vpc_dhcp_option_info

ADDITIONAL INFORMATION

@tremble tremble changed the title Drop deprecated (CamelCase) aliases [WIP] Drop deprecated (CamelCase) aliases Jul 5, 2022
@ansibullbot
Copy link

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request module module labels Jul 5, 2022
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jul 5, 2022
@tremble tremble force-pushed the deprecations/5.0.0/CamelCase branch from aea355b to 917c635 Compare July 5, 2022 13:14
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble force-pushed the deprecations/5.0.0/CamelCase branch from 917c635 to 0451b4d Compare July 5, 2022 13:57
@ansibullbot ansibullbot added tests tests and removed owner_pr PR created by owner/maintainer labels Jul 5, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble force-pushed the deprecations/5.0.0/CamelCase branch from 0451b4d to 2be138d Compare July 5, 2022 14:24
@tremble tremble changed the title [WIP] Drop deprecated (CamelCase) aliases Drop deprecated (CamelCase) aliases Jul 5, 2022
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Jul 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 38s
✔️ build-ansible-collection SUCCESS in 5m 21s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 58s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 12m 16s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 12m 57s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 06s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 59s
✔️ ansible-test-splitter SUCCESS in 2m 41s
✔️ integration-amazon.aws-1 SUCCESS in 19m 30s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 29m 47s
✔️ integration-community.aws-2 SUCCESS in 26m 35s
✔️ integration-community.aws-3 SUCCESS in 13m 14s
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 47s
✔️ build-ansible-collection SUCCESS in 5m 41s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 22s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 14s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 01s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 41s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 28s
✔️ ansible-test-splitter SUCCESS in 3m 06s
✔️ integration-amazon.aws-1 SUCCESS in 19m 01s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 9m 22s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ae5e8b6 into ansible-collections:main Jul 5, 2022
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 6, 2022
Update ec2_vpc_dhcp_option_info to remove deprecated alias

SUMMARY
With #913 the CamelCase aliases in ec2_vpc_dhcp_option_info were dropped.
Updates the example to use the snake case version
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/modules/ec2_vpc_dhcp_option_info.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
@tremble tremble deleted the deprecations/5.0.0/CamelCase branch September 9, 2022 08:53
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…e-collections#913)

Add deregistration_connection_termination to elb_target_group

SUMMARY
Adding support for the deregistration_connection_termination param in the elb_target_group module.
Along with this I've enabled and fixed up the integration tests.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_target_group
ADDITIONAL INFORMATION
The API param is deregistration_delay.connection_termination.enabled
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.describe_target_group_attributes

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…e-collections#913)

Add deregistration_connection_termination to elb_target_group

SUMMARY
Adding support for the deregistration_connection_termination param in the elb_target_group module.
Along with this I've enabled and fixed up the integration tests.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_target_group
ADDITIONAL INFORMATION
The API param is deregistration_delay.connection_termination.enabled
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.describe_target_group_attributes

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…e-collections#913)

Add deregistration_connection_termination to elb_target_group

SUMMARY
Adding support for the deregistration_connection_termination param in the elb_target_group module.
Along with this I've enabled and fixed up the integration tests.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_target_group
ADDITIONAL INFORMATION
The API param is deregistration_delay.connection_termination.enabled
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.describe_target_group_attributes

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants