adding encryption_bucket_key #866
Conversation
|
cc @jillr @linabuzachis @lwade @s-hertel @tremble |
ansibullbot
added
bug
|
@chirag1603, thanks for taking the time to submit this PR. This looks like an attempt to reimplement the encryption_key_id parameter from s3_bucket. aws_s3 is intended for managing objects in the bucket rather than the bucket itself. Have I misunderstood what you're trying to achieve with this change? |
|
@chirag1603 please modify also DOCUMENTATION= & RETURN= module sections and add some asserts into integration tests. You should verify that the particular bucket property was properly configured by the module. Thx. |
|
@chirag1603 please take a looks at
There's a piece of code touching Thanks |
|
@chirag1603 thank you for taking the time to submit this PR. Looking deeper into the Rather than adding this functionality into the aws_s3 module, duplicating code, and potentially leaving multiple places for the same bug to surface, I believe that it's better for us to let the s3_bucket module focus on creating and managing the buckets themselves, and focus the aws_s3 module focus on managing the objects (and directories) within the bucket. As such I'm going to close this PR. However, I've also opened #869 which I hope clarifies the intended scope of this module and makes it easier to see that we have both a module for managing the S3 bucket ( |
…869) Rename aws_s3 to s3_object (and deprecate bucket creation/deleting) SUMMARY The aws_s3 module (as it's known today) is primarily for managing objects within S3. While it provides minimal support for creating S3 buckets, the feature set is very limited. Support for the advanced bucket management features is provided via the s3_bucket modules (such as managing encryption settings). Because the name aws_s3 often puts the module at the top of the list of modules, well away from the s3_bucket module, it can be difficult for folks to discover the s3_bucket module leading them to assume that we simply have no support for the more complex s3_bucket management features. As such, I suggest renaming the module to s3_object to make the intended scope more obvious and to improve the discoverability of s3_bucket. At this time I do not recommend setting a deprecation date for the alias, the cost of an alias is minimal and we've had a lot of churn recently. Additionally, deprecates the duplicated (but very limited) bucket creation/deletion functionality of aws_s3/s3_object ISSUE TYPE Feature Pull Request COMPONENT NAME aws_s3 (s3_object) ADDITIONAL INFORMATION See for example #866 where there was an attempt to create duplicate functionality. Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None>
…nsible-collections#869) Rename aws_s3 to s3_object (and deprecate bucket creation/deleting) SUMMARY The aws_s3 module (as it's known today) is primarily for managing objects within S3. While it provides minimal support for creating S3 buckets, the feature set is very limited. Support for the advanced bucket management features is provided via the s3_bucket modules (such as managing encryption settings). Because the name aws_s3 often puts the module at the top of the list of modules, well away from the s3_bucket module, it can be difficult for folks to discover the s3_bucket module leading them to assume that we simply have no support for the more complex s3_bucket management features. As such, I suggest renaming the module to s3_object to make the intended scope more obvious and to improve the discoverability of s3_bucket. At this time I do not recommend setting a deprecation date for the alias, the cost of an alias is minimal and we've had a lot of churn recently. Additionally, deprecates the duplicated (but very limited) bucket creation/deletion functionality of aws_s3/s3_object ISSUE TYPE Feature Pull Request COMPONENT NAME aws_s3 (s3_object) ADDITIONAL INFORMATION See for example ansible-collections#866 where there was an attempt to create duplicate functionality. Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None>
) Update contributor doc to add changelog section SUMMARY Update contributor doc to add changelog section ISSUE TYPE Docs Pull Request COMPONENT NAME N/A ADDITIONAL INFORMATION N/A Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION