Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup_sshkey: drop a dep on Crypto #799

Merged
merged 1 commit into from
May 10, 2022
Merged

setup_sshkey: drop a dep on Crypto #799

merged 1 commit into from
May 10, 2022

Conversation

goneri
Copy link
Member

@goneri goneri commented Apr 29, 2022 •
edited
Loading

Adjust ec2-fingerprint.py so it use cryptography instead of the
deprecated Crypto library.

@goneri goneri mentioned this pull request Apr 29, 2022
Merged
@ansibullbot
Copy link

@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot ansibullbot added integration tests/integration needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage tests tests labels Apr 29, 2022
@goneri goneri mentioned this pull request Apr 29, 2022
Open
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

tremble
tremble previously requested changes May 2, 2022
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: tests/integration/targets/setup_sshkey/files/ec2-fingerprint.py:1:1: unexpected non-module shebang: b'#!/usr/bin/env python3'

Please also make sure that at least the ec2_key test is triggered.

@goneri
setup_sshkey: drop a dep on Crypto
690df9c 
Adjust ec2-fingerprint.py so it use cryptography instead of the
deprecated Crypto library.

Introduce a dummy change in ec2_key test-suite to trigger the
test-suite.
@goneri goneri force-pushed the setup_sshkey-drop-a-dep-on-Crypto_28536 branch from d14b533 to 690df9c Compare May 2, 2022 15:08
@ansibullbot
Copy link

cc @jillr @prasadkatti @s-hertel @tremble @zbal
click here for bot help

@ansibullbot ansibullbot added the plugins plugin (any type) label May 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@goneri
Copy link
Member Author

goneri commented May 2, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jillr jillr removed the needs_triage label May 3, 2022
@goneri goneri requested a review from tremble May 4, 2022 17:27
@goneri goneri added the mergeit Merge the PR (SoftwareFactory) label May 4, 2022
@goneri
Copy link
Member Author

goneri commented May 10, 2022

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 45s
✔️ build-ansible-collection SUCCESS in 4m 42s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 50s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 10m 40s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 11m 06s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 50s
✔️ ansible-test-splitter SUCCESS in 3m 45s
✔️ integration-amazon.aws-1 SUCCESS in 8m 21s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
❌ ansible-ee-tests-stable-2.12 FAILURE in 13m 12s (non-voting)

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b06fb7a into ansible-collections:main May 10, 2022
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 16, 2022
@markuman @alinabuzachis
route53: fix empty result set (ansible-collections#799)
57b2f48 
route53: fix empty result set

SUMMARY
Closes: ansible-collections#798
Using state: get on none existing records results in an error.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@markuman @goneri
route53: fix empty result set (ansible-collections#799)
f21d9ec 
route53: fix empty result set

SUMMARY
Closes: ansible-collections#798
Using state: get on none existing records results in an error.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@markuman @goneri
route53: fix empty result set (ansible-collections#799)
6da9c2e 
route53: fix empty result set

SUMMARY
Closes: ansible-collections#798
Using state: get on none existing records results in an error.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@markuman @goneri
route53: fix empty result set (ansible-collections#799)
846d2ca 
route53: fix empty result set

SUMMARY
Closes: ansible-collections#798
Using state: get on none existing records results in an error.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION
@gravesm gravesm mentioned this pull request Mar 29, 2023
Merged
gravesm added a commit to gravesm/amazon.aws that referenced this pull request Mar 29, 2023
@gravesm
Replace pycrypto test dependency
21089d7 
The dependency on pycrypto was replaced with cryptography almost a year
ago in ansible-collections#799, but
the test dependencies never got updated. Presumably, this worked because
Ansible depends on cryptography already.
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 31, 2023
@gravesm
Replace pycrypto test dependency (#1448)
dceef92 
Replace pycrypto test dependency

SUMMARY

The dependency on pycrypto was replaced with cryptography almost a year ago in #799, but the test dependencies never got updated. Presumably, this worked because Ansible depends on cryptography already.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@markuman
route53: fix empty result set (ansible-collections#799)
d50273d 
route53: fix empty result set

SUMMARY
Closes: ansible-collections#798
Using state: get on none existing records results in an error.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION
---
- hosts: localhost
  connection: local

  tasks:
    - community.aws.route53:
        state: get
        zone: xn--mitlinuxwrdasnichtpassiert-ohc.de
        record: doesnotexist.xn--mitlinuxwrdasnichtpassiert-ohc.de.
        type: A
      register: test

    - debug:
        var: test
results in
TASK [community.aws.route53] ********************************************************************************************************************************************************************************************************
task path: /home/m/git/lekker/iac/798.yml:6
<127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: m
<127.0.0.1> EXEC /bin/sh -c 'echo ~m && sleep 0'
<127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/m/.ansible/tmp `"&& mkdir "` echo /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765 `" && echo ansible-tmp-1636703337.6553104-21549-57181038135765="` echo /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765 `" ) && sleep 0'
Using module file /home/m/.local/lib/python3.9/site-packages/ansible_collections/community/aws/plugins/modules/route53.py
<127.0.0.1> PUT /home/m/.ansible/tmp/ansible-local-21466oog6jc4o/tmpeo_xv0k3 TO /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py
<127.0.0.1> EXEC /bin/sh -c 'chmod u+x /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/ /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py && sleep 0'
<127.0.0.1> EXEC /bin/sh -c '/usr/bin/python /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py && sleep 0'
<127.0.0.1> EXEC /bin/sh -c 'rm -f -r /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/ > /dev/null 2>&1 && sleep 0'
The full traceback is:
Traceback (most recent call last):
  File "/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py", line 100, in <module>
    _ansiballz_main()
  File "/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py", line 92, in _ansiballz_main
    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
  File "/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py", line 40, in invoke_module
    runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.route53', init_globals=dict(_module_fqn='ansible_collections.community.aws.plugins.modules.route53', _modlib_path=modlib_path),
  File "/usr/lib/python3.9/runpy.py", line 210, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/usr/lib/python3.9/runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py", line 698, in <module>
  File "/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py", line 636, in main
  File "/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible/module_utils/common/dict_transformations.py", line 42, in camel_dict_to_snake_dict
AttributeError: 'NoneType' object has no attribute 'items'
fatal: [localhost]: FAILED! => {
    "changed": false,
    "module_stderr": "Traceback (most recent call last):\n  File \"/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py\", line 100, in <module>\n    _ansiballz_main()\n  File \"/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py\", line 92, in _ansiballz_main\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File \"/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py\", line 40, in invoke_module\n    runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.route53', init_globals=dict(_module_fqn='ansible_collections.community.aws.plugins.modules.route53', _modlib_path=modlib_path),\n  File \"/usr/lib/python3.9/runpy.py\", line 210, in run_module\n    return _run_module_code(code, init_globals, run_name, mod_spec)\n  File \"/usr/lib/python3.9/runpy.py\", line 97, in _run_module_code\n    _run_code(code, mod_globals, init_globals,\n  File \"/usr/lib/python3.9/runpy.py\", line 87, in _run_code\n    exec(code, run_globals)\n  File \"/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py\", line 698, in <module>\n  File \"/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py\", line 636, in main\n  File \"/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible/module_utils/common/dict_transformations.py\", line 42, in camel_dict_to_snake_dict\nAttributeError: 'NoneType' object has no attribute 'items'\n",
    "module_stdout": "",
    "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
    "rc": 1
}

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@markuman @abikouo
route53: fix empty result set (ansible-collections#799)
d969b37 
route53: fix empty result set

SUMMARY
Closes: ansible-collections#798
Using state: get on none existing records results in an error.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION
---
- hosts: localhost
  connection: local

  tasks:
    - community.aws.route53:
        state: get
        zone: xn--mitlinuxwrdasnichtpassiert-ohc.de
        record: doesnotexist.xn--mitlinuxwrdasnichtpassiert-ohc.de.
        type: A
      register: test

    - debug:
        var: test
results in
TASK [community.aws.route53] ********************************************************************************************************************************************************************************************************
task path: /home/m/git/lekker/iac/798.yml:6
<127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: m
<127.0.0.1> EXEC /bin/sh -c 'echo ~m && sleep 0'
<127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/m/.ansible/tmp `"&& mkdir "` echo /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765 `" && echo ansible-tmp-1636703337.6553104-21549-57181038135765="` echo /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765 `" ) && sleep 0'
Using module file /home/m/.local/lib/python3.9/site-packages/ansible_collections/community/aws/plugins/modules/route53.py
<127.0.0.1> PUT /home/m/.ansible/tmp/ansible-local-21466oog6jc4o/tmpeo_xv0k3 TO /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py
<127.0.0.1> EXEC /bin/sh -c 'chmod u+x /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/ /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py && sleep 0'
<127.0.0.1> EXEC /bin/sh -c '/usr/bin/python /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py && sleep 0'
<127.0.0.1> EXEC /bin/sh -c 'rm -f -r /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/ > /dev/null 2>&1 && sleep 0'
The full traceback is:
Traceback (most recent call last):
  File "/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py", line 100, in <module>
    _ansiballz_main()
  File "/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py", line 92, in _ansiballz_main
    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
  File "/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py", line 40, in invoke_module
    runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.route53', init_globals=dict(_module_fqn='ansible_collections.community.aws.plugins.modules.route53', _modlib_path=modlib_path),
  File "/usr/lib/python3.9/runpy.py", line 210, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/usr/lib/python3.9/runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py", line 698, in <module>
  File "/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py", line 636, in main
  File "/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible/module_utils/common/dict_transformations.py", line 42, in camel_dict_to_snake_dict
AttributeError: 'NoneType' object has no attribute 'items'
fatal: [localhost]: FAILED! => {
    "changed": false,
    "module_stderr": "Traceback (most recent call last):\n  File \"/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py\", line 100, in <module>\n    _ansiballz_main()\n  File \"/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py\", line 92, in _ansiballz_main\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File \"/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py\", line 40, in invoke_module\n    runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.route53', init_globals=dict(_module_fqn='ansible_collections.community.aws.plugins.modules.route53', _modlib_path=modlib_path),\n  File \"/usr/lib/python3.9/runpy.py\", line 210, in run_module\n    return _run_module_code(code, init_globals, run_name, mod_spec)\n  File \"/usr/lib/python3.9/runpy.py\", line 97, in _run_module_code\n    _run_code(code, mod_globals, init_globals,\n  File \"/usr/lib/python3.9/runpy.py\", line 87, in _run_code\n    exec(code, run_globals)\n  File \"/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py\", line 698, in <module>\n  File \"/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py\", line 636, in main\n  File \"/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible/module_utils/common/dict_transformations.py\", line 42, in camel_dict_to_snake_dict\nAttributeError: 'NoneType' object has no attribute 'items'\n",
    "module_stdout": "",
    "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
    "rc": 1
}

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@markuman
route53: fix empty result set (ansible-collections#799)
e64ce9f 
route53: fix empty result set

SUMMARY
Closes: ansible-collections#798
Using state: get on none existing records results in an error.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION
---
- hosts: localhost
  connection: local

  tasks:
    - community.aws.route53:
        state: get
        zone: xn--mitlinuxwrdasnichtpassiert-ohc.de
        record: doesnotexist.xn--mitlinuxwrdasnichtpassiert-ohc.de.
        type: A
      register: test

    - debug:
        var: test
results in
TASK [community.aws.route53] ********************************************************************************************************************************************************************************************************
task path: /home/m/git/lekker/iac/798.yml:6
<127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: m
<127.0.0.1> EXEC /bin/sh -c 'echo ~m && sleep 0'
<127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/m/.ansible/tmp `"&& mkdir "` echo /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765 `" && echo ansible-tmp-1636703337.6553104-21549-57181038135765="` echo /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765 `" ) && sleep 0'
Using module file /home/m/.local/lib/python3.9/site-packages/ansible_collections/community/aws/plugins/modules/route53.py
<127.0.0.1> PUT /home/m/.ansible/tmp/ansible-local-21466oog6jc4o/tmpeo_xv0k3 TO /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py
<127.0.0.1> EXEC /bin/sh -c 'chmod u+x /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/ /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py && sleep 0'
<127.0.0.1> EXEC /bin/sh -c '/usr/bin/python /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py && sleep 0'
<127.0.0.1> EXEC /bin/sh -c 'rm -f -r /home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/ > /dev/null 2>&1 && sleep 0'
The full traceback is:
Traceback (most recent call last):
  File "/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py", line 100, in <module>
    _ansiballz_main()
  File "/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py", line 92, in _ansiballz_main
    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
  File "/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py", line 40, in invoke_module
    runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.route53', init_globals=dict(_module_fqn='ansible_collections.community.aws.plugins.modules.route53', _modlib_path=modlib_path),
  File "/usr/lib/python3.9/runpy.py", line 210, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/usr/lib/python3.9/runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py", line 698, in <module>
  File "/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py", line 636, in main
  File "/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible/module_utils/common/dict_transformations.py", line 42, in camel_dict_to_snake_dict
AttributeError: 'NoneType' object has no attribute 'items'
fatal: [localhost]: FAILED! => {
    "changed": false,
    "module_stderr": "Traceback (most recent call last):\n  File \"/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py\", line 100, in <module>\n    _ansiballz_main()\n  File \"/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py\", line 92, in _ansiballz_main\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File \"/home/m/.ansible/tmp/ansible-tmp-1636703337.6553104-21549-57181038135765/AnsiballZ_route53.py\", line 40, in invoke_module\n    runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.route53', init_globals=dict(_module_fqn='ansible_collections.community.aws.plugins.modules.route53', _modlib_path=modlib_path),\n  File \"/usr/lib/python3.9/runpy.py\", line 210, in run_module\n    return _run_module_code(code, init_globals, run_name, mod_spec)\n  File \"/usr/lib/python3.9/runpy.py\", line 97, in _run_module_code\n    _run_code(code, mod_globals, init_globals,\n  File \"/usr/lib/python3.9/runpy.py\", line 87, in _run_code\n    exec(code, run_globals)\n  File \"/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py\", line 698, in <module>\n  File \"/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py\", line 636, in main\n  File \"/tmp/ansible_community.aws.route53_payload_aekaeeo1/ansible_community.aws.route53_payload.zip/ansible/module_utils/common/dict_transformations.py\", line 42, in camel_dict_to_snake_dict\nAttributeError: 'NoneType' object has no attribute 'items'\n",
    "module_stdout": "",
    "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
    "rc": 1
}

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
@tremble tremble mentioned this pull request Nov 16, 2023
Merged
softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Nov 16, 2023
@tremble
setup_sshkey: drop a dep on Crypto (#2004)
42c0475 
setup_sshkey: drop a dep on Crypto

SUMMARY
Adjust ec2-fingerprint.py so it use cryptography instead of the deprecated Crypto library.
(originally written by Gonéri)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration/targets/setup_sshkey/files/ec2-fingerprint.py
ADDITIONAL INFORMATION
Original PR (amazon.aws)
ansible-collections/amazon.aws#799

Reviewed-by: Alina Buzachis
patchback bot pushed a commit to ansible-collections/community.aws that referenced this pull request Nov 16, 2023
@tremble @patchback
setup_sshkey: drop a dep on Crypto (#2004)
6eed090 
setup_sshkey: drop a dep on Crypto

SUMMARY
Adjust ec2-fingerprint.py so it use cryptography instead of the deprecated Crypto library.
(originally written by Gonéri)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration/targets/setup_sshkey/files/ec2-fingerprint.py
ADDITIONAL INFORMATION
Original PR (amazon.aws)
ansible-collections/amazon.aws#799

Reviewed-by: Alina Buzachis
(cherry picked from commit 42c0475)
@patchback patchback bot mentioned this pull request Nov 16, 2023
Merged
softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Nov 16, 2023
@patchback
setup_sshkey: drop a dep on Crypto (#2004) (#2005)
8aef2be 
[PR #2004/42c0475d backport][stable-7] setup_sshkey: drop a dep on Crypto

This is a backport of PR #2004 as merged into main (42c0475).
SUMMARY
Adjust ec2-fingerprint.py so it use cryptography instead of the deprecated Crypto library.
(originally written by Gonéri)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration/targets/setup_sshkey/files/ec2-fingerprint.py
ADDITIONAL INFORMATION
Original PR (amazon.aws)
ansible-collections/amazon.aws#799

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

@tremble tremble Awaiting requested review from tremble

Assignees
No one assigned
Labels
integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goneri @ansibullbot @tremble @jillr