Deprecate Camel- and Upper- case aliases #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're a relic from before we started standardising parameter names. While aliases like EC2_URL were removed S3_URL wasn't
|
cc @abikouo @jillr @linabuzachis @lwade @s-hertel |
ansibullbot
added
WIP
tremble
force-pushed
the
deprecate/S3_URL
branch
2 times, most recently
from
e45435f to
d1b9c1f
Compare
tremble
force-pushed
the
deprecate/S3_URL
branch
from
d1b9c1f to
a673cc6
Compare
tremble
force-pushed
the
deprecate/S3_URL
branch
from
a673cc6 to
df6a568
Compare
tremble
changed the title
alinabuzachis
approved these changes
May 2, 2022
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…nsible-collections#973) ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules SUMMARY Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback. Issue: ansible-collections#135 PR being revived: ansible-collections#795 Fixes ansible-collections#135 ISSUE TYPE New Module Pull Request COMPONENT NAME ec2_asg_instance_refresh ec2_asg_instance_refreshes_info ADDITIONAL INFORMATION More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/ Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…nsible-collections#973) ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules SUMMARY Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback. Issue: ansible-collections#135 PR being revived: ansible-collections#795 Fixes ansible-collections#135 ISSUE TYPE New Module Pull Request COMPONENT NAME ec2_asg_instance_refresh ec2_asg_instance_refreshes_info ADDITIONAL INFORMATION More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/ Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#973) ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules SUMMARY Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback. Issue: ansible-collections#135 PR being revived: ansible-collections#795 Fixes ansible-collections#135 ISSUE TYPE New Module Pull Request COMPONENT NAME ec2_asg_instance_refresh ec2_asg_instance_refreshes_info ADDITIONAL INFORMATION More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/ Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Clean up aliases.
S3_URL is a quirk from the very early code base and wasn't cleaned up when the original cleanup was done (in 2014!)
The CamelCase parameters were originally for compatibility.
ISSUE TYPE
COMPONENT NAME
s3_bucket
aws_s3
ec2_vpc_dhcp_option_info aliases
ec2_ami
ADDITIONAL INFORMATION
S3_URL is causing linting issues with the docs:
/home/runner/work/_temp/docsbuild/rst/collections/amazon/aws/aws_s3_module.rst:1478: WARNING: Duplicate explicit target name: "ansible_collections.amazon.aws.aws_s3_module__parameter-s3_url".