Create extra snapshots for ec2_snapshot_info test - minimum max_results is 5 #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinabuzachis
approved these changes
Apr 21, 2022
ansibullbot
added
bug
|
recheck |
|
recheck |
tremble
force-pushed
the
backport/stable-1.5/pull-356-tests
branch
from
dada8f8 to
04284cf
Compare
tremble
force-pushed
the
backport/stable-1.5/pull-356-tests
branch
from
04284cf to
cf04b5a
Compare
softwarefactory-project-zuul
bot
merged commit 19c23db
into
ansible-collections:stable-1.5
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…r auto. (ansible-collections#1633) Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. SUMMARY Added the chance of setting up the addressing style for S3 URLs, this fixes ansible-collections#637 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION I came across this issue when I was trying to connect and execute tasks on a fresh AWS set-up (new S3 bucket + EC2), I'm using the latest (5.1.0) release and Ansible 5.10 (as per pip show). The issue itself is the same as ansible-collections#637 and the last comment is the fix, there's another PR addressing this issue ansible-collections#786 but is quiet since May Also AWS seems to be deprecating PATH addressing style: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access Thanks to timburnet-systematica and james-masson for their initial work on this. Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial backport of PR #356 as merged into main (b7087f4).
SUMMARY
Fixes a bug in the integration test
ISSUE TYPE
COMPONENT NAME
ec2_snapshot_info
ADDITIONAL INFORMATION