[PR #632/8b061bd8 backport][stable-1.5] Disable broken integration test - lookup_aws_account_attribute #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Disable broken integration test - lookup_aws_account_attribute SUMMARY After going through the joys of bisecting recent changes ansible/ansible#75587 appears to have broken the test when running 'wantlist=False' ISSUE TYPE Feature Pull Request COMPONENT NAME aws_account_attribute ADDITIONAL INFORMATION TASK [lookup_aws_account_attribute : Fetch all account attributes (wantlist=False)] ******************************************************************************************************************************* task path: /root/ansible_collections/amazon/aws/tests/output/.tmp/integration/lookup_aws_account_attribute-bjtiq49h-ÅÑŚÌβŁÈ/tests/integration/targets/lookup_aws_account_attribute/tasks/main.yaml:50 The full traceback is: Traceback (most recent call last): File "/root/ansible/lib/ansible/executor/task_executor.py", line 503, in _execute self._task.post_validate(templar=templar) File "/root/ansible/lib/ansible/playbook/task.py", line 283, in post_validate super(Task, self).post_validate(templar) File "/root/ansible/lib/ansible/playbook/base.py", line 650, in post_validate value = templar.template(getattr(self, name)) File "/root/ansible/lib/ansible/template/__init__.py", line 874, in template d[k] = self.template( File "/root/ansible/lib/ansible/template/__init__.py", line 842, in template result = self.do_template( File "/root/ansible/lib/ansible/template/__init__.py", line 1101, in do_template res = ansible_concat(rf, convert_data, myenv.variable_start_string) File "/root/ansible/lib/ansible/template/native_helpers.py", line 60, in ansible_concat head = list(islice(nodes, 2)) File "<template>", line 13, in root File "/usr/lib/python3.10/dist-packages/jinja2/runtime.py", line 349, in call return __obj(*args, **kwargs) File "/root/ansible/lib/ansible/template/__init__.py", line 1013, in _lookup if isinstance(ran[0], NativeJinjaText): KeyError: 0 fatal: [testhost]: FAILED! => { "changed": false } Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> (cherry picked from commit 8b061bd)
tremble
approved these changes
Apr 21, 2022
ansibullbot
added
community_review
feature
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-1.5/8b061bd8276af6884ba528705eccd0f06d95627c/pr-632
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ns#785) added clarification on SSE and `kms_master_key_id` SUMMARY Added note about kms_master_key_id and how SSE is enabled automatically. ISSUE TYPE Docs Pull Request COMPONENT NAME sqs_queue Reviewed-by: Mark Chappell <None> Reviewed-by: James McClune <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ns#785) added clarification on SSE and `kms_master_key_id` SUMMARY Added note about kms_master_key_id and how SSE is enabled automatically. ISSUE TYPE Docs Pull Request COMPONENT NAME sqs_queue Reviewed-by: Mark Chappell <None> Reviewed-by: James McClune <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ns#785) added clarification on SSE and `kms_master_key_id` SUMMARY Added note about kms_master_key_id and how SSE is enabled automatically. ISSUE TYPE Docs Pull Request COMPONENT NAME sqs_queue Reviewed-by: Mark Chappell <None> Reviewed-by: James McClune <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #632 as merged into main (8b061bd).
SUMMARY
After going through the joys of bisecting recent changes ansible/ansible#75587 appears to have broken the test when running 'wantlist=False'
ISSUE TYPE
COMPONENT NAME
aws_account_attribute
ADDITIONAL INFORMATION