Add support for icmp_type and icmp_code parameters (close #628) #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
docs
feature
|
The job mentions the following: ERROR: plugins/modules/ec2_group.py:0:0: doc-default-does-not-match-spec: Argument 'purge_rules' in argument_spec defines default as (True) but documentation defines default as (False)
ERROR: plugins/modules/ec2_group.py:0:0: doc-default-does-not-match-spec: Argument 'purge_rules_egress' in argument_spec defines default as (True) but documentation defines default as (False)
ERROR: plugins/modules/ec2_group.py:0:0: doc-default-does-not-match-spec: Argument 'purge_tags' in argument_spec defines default as (True) but documentation defines default as (False)
ERROR: plugins/modules/ec2_group.py:0:0: doc-default-does-not-match-spec: Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
ERROR: plugins/modules/ec2_group.py:0:0: doc-default-does-not-match-spec: Argument 'validate_certs' in argument_spec defines default as (True) but documentation defines default as (False)
ERROR: plugins/modules/ec2_group.py:0:0: doc-missing-type: Argument 'aws_access_key' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: doc-missing-type: Argument 'aws_secret_key' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: doc-missing-type: Argument 'description' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: doc-missing-type: Argument 'ec2_url' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: doc-missing-type: Argument 'group_id' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: doc-missing-type: Argument 'name' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: doc-missing-type: Argument 'profile' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: doc-missing-type: Argument 'region' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: doc-missing-type: Argument 'security_token' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: doc-missing-type: Argument 'vpc_id' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'aws_ca_bundle' in argument_spec defines type as 'path' but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'aws_config' in argument_spec defines type as 'dict' but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'debug_botocore_endpoint_logs' in argument_spec defines type as 'bool' but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'purge_rules' in argument_spec defines type as 'bool' but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'purge_rules_egress' in argument_spec defines type as 'bool' but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'purge_tags' in argument_spec defines type as 'bool' but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'rules' in argument_spec defines type as 'list' but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'rules_egress' in argument_spec defines type as 'list' but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'tags' in argument_spec defines type as 'dict' but documentation doesn't define type
ERROR: plugins/modules/ec2_group.py:0:0: parameter-type-not-in-doc: Argument 'validate_certs' in argument_spec defines type as 'bool' but documentation doesn't define typeTaking the first error: ERROR: plugins/modules/ec2_group.py:0:0: doc-default-does-not-match-spec: Argument 'purge_rules' in argument_spec defines default as (True) but documentation defines default as (False)However, I do see that purge_rules:
description:
- Purge existing rules on security group that are not found in rules.
required: false
default: 'true'
aliases: []
type: bool |
|
A slew of errors like that usually means it's failed to parse the docs properly, which in turn results in lots of "mismatched" types |
plugins/modules/ec2_group.py
Outdated
Comment on lines
195
to
206
| icmp_type: | ||
| type: int | ||
| description: | ||
| - When using C(proto: icmp) or C(proto: icmpv6), allows you to specify | ||
| - the ICMP type to use. The option is mutually exclusive with from_port. | ||
| - A value of C(-1) indicates all ICMP types. | ||
| icmp_code: | ||
| type: int | ||
| description: | ||
| - When using C(proto: icmp) or C(proto: icmpv6), allows you to specify | ||
| - the ICMP code to use. The option is mutually exclusive with C(to_port). | ||
| - A value of C(-1) indicates all ICMP codes. |
There was a problem hiding this comment.
I guess these are redundant since you have already specified these parameters in the documentation.
There was a problem hiding this comment.
I wasn't sure whether the documentation section in the code was used elsewhere, such as via the ansible-docs command. Should I should remove these two entries?
Co-authored-by: Alina Buzachis <[email protected]>
Co-authored-by: Alina Buzachis <[email protected]>
Co-authored-by: Alina Buzachis <[email protected]>
Co-authored-by: Alina Buzachis <[email protected]>
Co-authored-by: Alina Buzachis <[email protected]>
Co-authored-by: Alina Buzachis <[email protected]>
tremble
reviewed
Apr 25, 2022
plugins/modules/ec2_group.py
Outdated
| version_added: 3.3.0 | ||
| type: int | ||
| description: | ||
| - When using C(proto: icmp) or C(proto: icmpv6), allows you to |
There was a problem hiding this comment.
2022-04-22 22:56:43.230449 | controller | ERROR: Found 2 yamllint issue(s) which need to be resolved:
2022-04-22 22:56:43.230573 | controller | ERROR: plugins/modules/ec2_group.py:117:49: error: DOCUMENTATION: syntax error: mapping values are not allowed here (syntax)
2022-04-22 22:56:43.230844 | controller | ERROR: plugins/modules/ec2_group.py:117:49: unparsable-with-libyaml: None - mapping values are not allowed in this context
This is likely what triggered the big slew of errors, the : is interpreted by YAML as the divider between the key and value. (this catches me out too)
There was a problem hiding this comment.
This is a good catch. It seems that treating colons as dividers between keys and values regardless of where they are is entirely up the parser. It never occurred to me that this would happen. I'll use the equal sign.
|
recheck |
tremble
reviewed
May 16, 2022
tremble
approved these changes
May 17, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 16, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 16, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4c44372
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Rename rds_snapshot to rds_instance_snapshot SUMMARY Rename rds_snapshot to rds_instance_snapshot since rds_snapshot only handles snapshotting of DB instances. A new module for snapshotting RDS clusters will be added in a future PR. ISSUE TYPE New Module Pull Request COMPONENT NAME rds_snapshot Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request add support for new
icmp_typeandicmp_codeparameters withproto: icmporproto: icmpv6. This initial suggestion was aimed at closing the inconsistency when the meaning offrom_portandto_portwould change based on the protocol type.Fixes #628
ISSUE TYPE
COMPONENT NAME
ec2_group