Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vol/test: gives more time to convert vol to gp3 #739

Conversation

goneri
Copy link
Member

@goneri goneri commented Mar 25, 2022

We give 9s to convert the volumne to gp3, in some cases this is not
enough.
Closes: #738

We give 9s to convert the volumne to gp3, in some cases this is not
enough.
Closes: ansible-collections#738
@ansibullbot
Copy link

@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added integration tests/integration needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) small_patch Hopefully easy to review tests tests labels Mar 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Mar 28, 2022
@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Mar 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit df865b4 into ansible-collections:main Mar 28, 2022
@patchback
Copy link

patchback bot commented Mar 28, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/df865b4c56d06c6086cb2d2443931122e9f03f10/pr-739

Backported as #742

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 28, 2022
ec2_vol/test: gives more time to convert vol to gp3

We give 9s to convert the volumne to gp3, in some cases this is not
enough.
Closes: #738

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit df865b4)
@patchback
Copy link

patchback bot commented Mar 28, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/df865b4c56d06c6086cb2d2443931122e9f03f10/pr-739

Backported as #744

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 28, 2022
ec2_vol/test: gives more time to convert vol to gp3

We give 9s to convert the volumne to gp3, in some cases this is not
enough.
Closes: #738

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit df865b4)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 28, 2022
setup_botocore_pip: create tempdir in /var/tmp

Depends-On: ansible/ansible-zuul-jobs#1418
Depends-On: #739
Depends-On: #739
Depends-On: #740
/tmp is based on ramfs and is not suitable for large files.
/var/tmp should be used instead.
See: https://fedoraproject.org/wiki/Features/tmp-on-tmpfs

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
patchback bot pushed a commit that referenced this pull request Mar 28, 2022
setup_botocore_pip: create tempdir in /var/tmp

Depends-On: ansible/ansible-zuul-jobs#1418
Depends-On: #739
Depends-On: #739
Depends-On: #740
/tmp is based on ramfs and is not suitable for large files.
/var/tmp should be used instead.
See: https://fedoraproject.org/wiki/Features/tmp-on-tmpfs

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit aeba19a)
patchback bot pushed a commit that referenced this pull request Mar 28, 2022
setup_botocore_pip: create tempdir in /var/tmp

Depends-On: ansible/ansible-zuul-jobs#1418
Depends-On: #739
Depends-On: #739
Depends-On: #740
/tmp is based on ramfs and is not suitable for large files.
/var/tmp should be used instead.
See: https://fedoraproject.org/wiki/Features/tmp-on-tmpfs

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit aeba19a)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 28, 2022
[PR #734/aeba19a6 backport][stable-3] setup_botocore_pip: create tempdir in /var/tmp

This is a backport of PR #734 as merged into main (aeba19a).
Depends-On: ansible/ansible-zuul-jobs#1418
Depends-On: #739
Depends-On: #739
Depends-On: #740
/tmp is based on ramfs and is not suitable for large files.
/var/tmp should be used instead.
See: https://fedoraproject.org/wiki/Features/tmp-on-tmpfs
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 28, 2022
[PR #739/df865b4c backport][stable-3] ec2_vol/test: gives more time to convert vol to gp3

This is a backport of PR #739 as merged into main (df865b4).
We give 9s to convert the volumne to gp3, in some cases this is not
enough.
Closes: #738
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 29, 2022
[PR #734/aeba19a6 backport][stable-2] setup_botocore_pip: create tempdir in /var/tmp

This is a backport of PR #734 as merged into main (aeba19a).
Depends-On: ansible/ansible-zuul-jobs#1418
Depends-On: #739
Depends-On: #739
Depends-On: #740
/tmp is based on ramfs and is not suitable for large files.
/var/tmp should be used instead.
See: https://fedoraproject.org/wiki/Features/tmp-on-tmpfs
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 12, 2022
[PR #739/df865b4c backport][stable-2] ec2_vol/test: gives more time to convert vol to gp3

This is a backport of PR #739 as merged into main (df865b4).
We give 9s to convert the volumne to gp3, in some cases this is not
enough.
Closes: #738

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…pretry_strings

sns_topic - Define shape for delivery_policy.

SUMMARY
delivery_policy was previously defined just as "dict", this meant that if someone passed in JSON or quoted the numbers, AWS would spit errors at them.
By defining the shape of delivery_policy Ansible will automatically convert "10" to 10, as well as providing cleaner error messages for missing components of the policy.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
sns_topic
ADDITIONAL INFORMATION
obsoletes ansible-collections#716

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…pretry_strings

sns_topic - Define shape for delivery_policy.

SUMMARY
delivery_policy was previously defined just as "dict", this meant that if someone passed in JSON or quoted the numbers, AWS would spit errors at them.
By defining the shape of delivery_policy Ansible will automatically convert "10" to 10, as well as providing cleaner error messages for missing components of the policy.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
sns_topic
ADDITIONAL INFORMATION
obsoletes ansible-collections#716

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) small_patch Hopefully easy to review tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume must be from type gp3
3 participants