-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #728/6d0e2948 backport][stable-3] Prevent CI to be run for whole collection #732
Merged
softwarefactory-project-zuul
merged 1 commit into
stable-3
from
patchback/backports/stable-3/6d0e29481f01d478c8f24e4a5198285d3b76c2cf/pr-728
Mar 25, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent CI to be run for whole collection SUMMARY Add a fake integration suite including an aliases file listing every module name with missing integration tests. This fake suite is necessary for the new CI ansible-test-splitter behaviour. If one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped. Track Issue: #729 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 6d0e294)
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
needs_triage
new_contributor
Help guide this first time contributor
tests
tests
labels
Mar 23, 2022
recheck |
recheck |
recheck |
jillr
approved these changes
Mar 25, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/6d0e29481f01d478c8f24e4a5198285d3b76c2cf/pr-728
branch
March 25, 2022 22:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
needs_triage
new_contributor
Help guide this first time contributor
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #728 as merged into main (6d0e294).
SUMMARY
Add a fake integration suite including an aliases file listing every module name with missing integration tests.
This fake suite is necessary for the new CI ansible-test-splitter behaviour. If one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped.
Track Issue: #729
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION