[PR #631/3e24a37b backport][stable-3] vpc_net check mode, IPV6 CIDR assoc/disassoc #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
vpc_net check mode, IPV6 CIDR assoc/disassoc SUMMARY Implement check mode correctly for the ec2_vpc_net module. The module was incorrectly making actual changes when executed in check mode. In check mode, do not change the configuration. Previously the module was making VPC changes in the following scenarios: Association with IPv4 CIDR or IPv6 CIDR. Disassociation from IPv4 CIDR or IPv6 CIDR. Handle case when Amazon-provided ipv6 block is enabled, then disabled, then enabled again. Do not disable IPv6 CIDR association (using Amazon pool) if ipv6_cidr property is not present in the task. If the VPC already exists and ipv6_cidr property, retain the current config. Add integration tests: Enable, disable, then re-enable Amazon-provided IPv6 CIDR. When VPC already exists and ipv6_cidr property is not specified, validate this does not disable IPv6 CIDR association. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_net ADDITIONAL INFORMATION Reviewed-by: Sebastien Rosset <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 3e24a37)
ansibullbot
added
bug
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/3e24a37b3f0c6678c3936a8a6cf228e02c64068c/pr-631
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #631 as merged into main (3e24a37).
SUMMARY
Implement check mode correctly for the
ec2_vpc_netmodule. The module was incorrectly making actual changes when executed in check mode.ipv6_cidrproperty is not present in the task. If the VPC already exists andipv6_cidrproperty, retain the current config.ipv6_cidrproperty is not specified, validate this does not disable IPv6 CIDR association.ISSUE TYPE
COMPONENT NAME
ec2_vpc_net
ADDITIONAL INFORMATION