-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add S3 bucket owner enforcement #694
Merged
softwarefactory-project-zuul
merged 5 commits into
ansible-collections:main
from
Tyler-2:add-object-ownership-enforcement
Mar 24, 2022
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
minor_changes: | ||
- s3_bucket - Add support for enforced bucket owner object ownership. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,12 +124,16 @@ | |
object_ownership: | ||
description: | ||
- Allow bucket's ownership controls. | ||
- C(BucketOwnerEnforced) - ACLs are disabled and no longer affect access permissions to your | ||
bucket. Requests to set or update ACLs fail. However, requests to read ACLs are supported. | ||
Bucket owner has full ownership and control. Object writer no longer has full ownership and | ||
control. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you please add something like: |
||
- C(BucketOwnerPreferred) - Objects uploaded to the bucket change ownership to the bucket owner | ||
if the objects are uploaded with the bucket-owner-full-control canned ACL. | ||
- C(ObjectWriter) - The uploading account will own the object | ||
if the object is uploaded with the bucket-owner-full-control canned ACL. | ||
- This option cannot be used together with a I(delete_object_ownership) definition. | ||
choices: [ 'BucketOwnerPreferred', 'ObjectWriter' ] | ||
choices: [ 'BucketOwnerEnforced', 'BucketOwnerPreferred', 'ObjectWriter' ] | ||
type: str | ||
version_added: 2.0.0 | ||
delete_object_ownership: | ||
|
@@ -1016,7 +1020,7 @@ def main(): | |
block_public_policy=dict(type='bool', default=False), | ||
restrict_public_buckets=dict(type='bool', default=False))), | ||
delete_public_access=dict(type='bool', default=False), | ||
object_ownership=dict(type='str', choices=['BucketOwnerPreferred', 'ObjectWriter']), | ||
object_ownership=dict(type='str', choices=['BucketOwnerEnforced', 'BucketOwnerPreferred', 'ObjectWriter']), | ||
delete_object_ownership=dict(type='bool', default=False), | ||
acl=dict(type='str', choices=['private', 'public-read', 'public-read-write', 'authenticated-read']), | ||
validate_bucket_name=dict(type='bool', default=True), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.