Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_route_table - support associating internet gateways #690

Merged
merged 16 commits into from
Mar 29, 2022
Merged

ec2_vpc_route_table - support associating internet gateways #690

merged 16 commits into from
Mar 29, 2022

Conversation

jatorcasso
Copy link
Contributor

@jatorcasso jatorcasso commented Feb 22, 2022 •
edited
Loading

Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_route_table

@ansibullbot
Copy link

cc @jillr @s-hertel @tremble @willthames
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Feb 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@alinabuzachis
Copy link
Collaborator

@jatorcasso I'll debug the module ec2_vpc_igw module tomorrow, but if you want to anticipate feel free to do it.

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jatorcasso
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@abikouo
Copy link
Contributor

abikouo commented Feb 24, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@goneri
Copy link
Member

goneri commented Feb 24, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

@goneri
Copy link
Member

goneri commented Feb 24, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

mandar242
mandar242 reviewed Feb 25, 2022
View reviewed changes
Copy link
Contributor

@mandar242 mandar242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor things - otherwise LGTM!

tests/integration/targets/ec2_vpc_route_table/tasks/main.yml Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_route_table.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jatorcasso
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis requested a review from markuman March 24, 2022 09:50
@alinabuzachis alinabuzachis added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Mar 25, 2022
@jatorcasso jatorcasso closed this Mar 25, 2022
@jatorcasso jatorcasso reopened this Mar 25, 2022
@alinabuzachis alinabuzachis removed the mergeit Merge the PR (SoftwareFactory) label Mar 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@marknet15
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Mar 29, 2022
@alinabuzachis alinabuzachis linked an issue Mar 29, 2022 that may be closed by this pull request
Update ec2_vpc_route_table to support associating internet gateways #476
Closed
1 task
@alinabuzachis alinabuzachis dismissed abikouo’s stale review March 29, 2022 14:58

It hangs merging and it seems the requests have been addressed.

@alinabuzachis
Copy link
Collaborator

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d9d5d0d into ansible-collections:main Mar 29, 2022
@patchback
Copy link

patchback bot commented Mar 29, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/d9d5d0d71ec4280602694c3b5f1510087cc63876/pr-690

Backported as #757

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 29, 2022
@jatorcasso @patchback
ec2_vpc_route_table - support associating internet gateways (#690)
d1f5339 
ec2_vpc_route_table - support associating internet gateways

Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY

Update ec2_vpc_route_table to support associating internet gateways per feature request #476
Add integration tests
Fix idempotency issue when associating a subnet with a route table

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_route_table

Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Mark Woolley <[email protected]>
(cherry picked from commit d9d5d0d)
@patchback patchback bot mentioned this pull request Mar 29, 2022
Merged
@jatorcasso jatorcasso deleted the ec2_vpc_route_table_igw branch March 29, 2022 16:34
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 29, 2022
@patchback
ec2_vpc_route_table - support associating internet gateways (#690) (#757
36a67bb 
)

[PR #690/d9d5d0d7 backport][stable-3] ec2_vpc_route_table - support associating internet gateways

This is a backport of PR #690 as merged into main (d9d5d0d).
Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY

Update ec2_vpc_route_table to support associating internet gateways per feature request #476
Add integration tests
Fix idempotency issue when associating a subnet with a route table

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_route_table
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Mar 31, 2022
@patchback @alinabuzachis
ec2_vpc_route_table - support associating internet gateways (ansible-…
9e62fff 
…collections#690) (ansible-collections#757)

[PR ansible-collections#690/d9d5d0d7 backport][stable-3] ec2_vpc_route_table - support associating internet gateways

This is a backport of PR ansible-collections#690 as merged into main (d9d5d0d).
Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY

Update ec2_vpc_route_table to support associating internet gateways per feature request ansible-collections#476
Add integration tests
Fix idempotency issue when associating a subnet with a route table

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_route_table
@renovate renovate bot mentioned this pull request Jul 13, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 18, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Oct 4, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesm gravesm gravesm left review comments

@tremble tremble tremble left review comments

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@marknet15 marknet15 marknet15 approved these changes

@Akasurde Akasurde Awaiting requested review from Akasurde

@mandar242 mandar242 Awaiting requested review from mandar242

@abikouo abikouo Awaiting requested review from abikouo

@markuman markuman Awaiting requested review from markuman

Assignees
No one assigned
Labels
backport-3 PR should be backported to the stable-3 branch community_review feature This issue/PR relates to a feature request has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module_utils module_utils module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ec2_vpc_route_table to support associating internet gateways
10 participants
@jatorcasso @ansibullbot @alinabuzachis @abikouo @goneri @marknet15 @tremble @Akasurde @gravesm @mandar242