Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ec2_instance.py #652

Merged

Conversation

IPvSean
Copy link
Contributor

@IPvSean IPvSean commented Feb 2, 2022

SUMMARY

vpc_subnet_id is not configurable under the network key, just tried a copy of the example and got this error->

TASK [manage_ec2_instances : Create EC2 instances for ansible node (control node)] **********************************************************************************************************
fatal: [localhost]: FAILED! => changed=false
  msg: No default subnet could be found - you must include a VPC subnet ID (vpc_subnet_id parameter) to create an instance

changing to match other examples

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

n/a, only see one bad example here

vpc_subnet_id is not configurable under the network key, just tried a copy of the example and got this error->

```
TASK [manage_ec2_instances : Create EC2 instances for ansible node (control node)] **********************************************************************************************************
fatal: [localhost]: FAILED! => changed=false
  msg: No default subnet could be found - you must include a VPC subnet ID (vpc_subnet_id parameter) to create an instance
```

changing to match other examples
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage plugins plugin (any type) small_patch Hopefully easy to review labels Feb 2, 2022
@goneri
Copy link
Member

goneri commented Feb 3, 2022

recheck

@alinabuzachis alinabuzachis added backport-3 PR should be backported to the stable-3 branch backport-2 PR should be backported to the stable-2 branch mergeit Merge the PR (SoftwareFactory) labels Feb 4, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4e9aec7 into ansible-collections:main Feb 4, 2022
@patchback
Copy link

patchback bot commented Feb 4, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/4e9aec7953d96a7c08ae76d9b9f95a18b0ca8358/pr-652

Backported as #653

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 4, 2022
Update ec2_instance.py

SUMMARY
vpc_subnet_id is not configurable under the network key, just tried a copy of the example and got this error->
TASK [manage_ec2_instances : Create EC2 instances for ansible node (control node)] **********************************************************************************************************
fatal: [localhost]: FAILED! => changed=false
  msg: No default subnet could be found - you must include a VPC subnet ID (vpc_subnet_id parameter) to create an instance

changing to match other examples
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION
n/a, only see one bad example here

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 4e9aec7)
@patchback
Copy link

patchback bot commented Feb 4, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/4e9aec7953d96a7c08ae76d9b9f95a18b0ca8358/pr-652

Backported as #654

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 4, 2022
Update ec2_instance.py

SUMMARY
vpc_subnet_id is not configurable under the network key, just tried a copy of the example and got this error->
TASK [manage_ec2_instances : Create EC2 instances for ansible node (control node)] **********************************************************************************************************
fatal: [localhost]: FAILED! => changed=false
  msg: No default subnet could be found - you must include a VPC subnet ID (vpc_subnet_id parameter) to create an instance

changing to match other examples
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION
n/a, only see one bad example here

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 4e9aec7)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 9, 2022
[PR #652/4e9aec79 backport][stable-3] Update ec2_instance.py

This is a backport of PR #652 as merged into main (4e9aec7).
SUMMARY
vpc_subnet_id is not configurable under the network key, just tried a copy of the example and got this error->
TASK [manage_ec2_instances : Create EC2 instances for ansible node (control node)] **********************************************************************************************************
fatal: [localhost]: FAILED! => changed=false
  msg: No default subnet could be found - you must include a VPC subnet ID (vpc_subnet_id parameter) to create an instance

changing to match other examples
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION
n/a, only see one bad example here
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 9, 2022
[PR #652/4e9aec79 backport][stable-2] Update ec2_instance.py

This is a backport of PR #652 as merged into main (4e9aec7).
SUMMARY
vpc_subnet_id is not configurable under the network key, just tried a copy of the example and got this error->
TASK [manage_ec2_instances : Create EC2 instances for ansible node (control node)] **********************************************************************************************************
fatal: [localhost]: FAILED! => changed=false
  msg: No default subnet could be found - you must include a VPC subnet ID (vpc_subnet_id parameter) to create an instance

changing to match other examples
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION
n/a, only see one bad example here
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…_ec2_vpc_nat_gateway

Migrate ec2_vpc_nat_gateway* modules and tests

Depends-On: ansible-collections#410
Remove ec2_vpc_nat_gateway* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…_ec2_vpc_nat_gateway

Migrate ec2_vpc_nat_gateway* modules and tests

Depends-On: ansible-collections#410
Remove ec2_vpc_nat_gateway* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch community_review docs mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants