Splitup core.py and move non-EC2 code from ec2.py #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
added
the
do_not_backport
ansibullbot
added
community_review
feature
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tremble
force-pushed
the
refactor
branch
2 times, most recently
from
4f683fa to
9cfb3d6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
recheck |
alinabuzachis
approved these changes
Feb 1, 2022
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Feb 1, 2022
…aws (#914) Fix unit tests which broke due to things being moved about in amazon.aws Depends-On: ansible/ansible-zuul-jobs#1324 SUMMARY ansible-collections/amazon.aws#649 moved a few things around, including a "private" wrapper class. The shuffles broke part of the monkey patching in some unit tests, and the private wrapper class wasn't made available in the old location (it's private, using it might result in things breaking) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/unit/plugins/modules/test_aws_api_gateway.py tests/unit/plugins/modules/test_ec2_vpc_vpn.py ADDITIONAL INFORMATION CC @marknet15 Reviewed-by: Gonéri Le Bouder <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…sible-collections#933) ec2_asg: Add functionality to detach specified instances from ASG SUMMARY Adds feature to detach specified instances from a AutoScalingGroup rather than terminating them directly. Detached instances are not terminated and can be managed independently. Implements ansible-collections#649 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_asg ADDITIONAL INFORMATION Makes use of https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.detach_instances Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…sible-collections#933) ec2_asg: Add functionality to detach specified instances from ASG SUMMARY Adds feature to detach specified instances from a AutoScalingGroup rather than terminating them directly. Detached instances are not terminated and can be managed independently. Implements ansible-collections#649 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_asg ADDITIONAL INFORMATION Makes use of https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.detach_instances Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…sible-collections#933) ec2_asg: Add functionality to detach specified instances from ASG SUMMARY Adds feature to detach specified instances from a AutoScalingGroup rather than terminating them directly. Detached instances are not terminated and can be managed independently. Implements ansible-collections#649 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_asg ADDITIONAL INFORMATION Makes use of https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.detach_instances Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 19, 2024
…aws (ansible-collections#914) Fix unit tests which broke due to things being moved about in amazon.aws Depends-On: ansible/ansible-zuul-jobs#1324 SUMMARY ansible-collections#649 moved a few things around, including a "private" wrapper class. The shuffles broke part of the monkey patching in some unit tests, and the private wrapper class wasn't made available in the old location (it's private, using it might result in things breaking) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/unit/plugins/modules/test_aws_api_gateway.py tests/unit/plugins/modules/test_ec2_vpc_vpn.py ADDITIONAL INFORMATION CC @marknet15 Reviewed-by: Gonéri Le Bouder <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3e30e37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Many of the functions in ec2.py were there primarily as a quirk of the AWS utility code living solely in ec2.py at the time it was written (no other aws utility code existed at the time). Since it isn't specific to the EC2 service, split it out.
Similarly, the core.py code came from a time when we were in with the rest of the Ansible code, so it became a general dumping ground. We don't need to worry about collisions with non-AWS module_util code now, let's break it apart to avoid potential circular dependencies.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/ec2.py
plugins/module_utils/core.py
ADDITIONAL INFORMATION