Move AWSRetry out of module_utils.ec2 #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
goneri
added
mergeit
|
Oops, I've applied the |
|
Build succeeded.
|
alinabuzachis
approved these changes
Jan 28, 2022
tremble
added
do_not_backport
|
Build succeeded (gate pipeline).
|
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ec2_vpc_endpoint_6324 tests: disable ec2_vpc_endpoint SUMMARY Its test-suite fails in the CI. See: ansible-collections#642 ISSUE TYPE Bugfix Pull Request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
AWSRetry living in the module_utils.ec2 is primarily a quirk of the AWS utility code living solely in ec2.py at the time it was written (no other aws utility code existed at the time). Since it isn't specific to the EC2 service split it out.
Long term I'd like to get to a state where module_utils.ec2 only includes code specific to the EC2 service.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/ec2.py
ADDITIONAL INFORMATION