Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #636

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Fix typo #636

merged 1 commit into from
Feb 9, 2022

Conversation

AleksaC
Copy link
Contributor

@AleksaC AleksaC commented Jan 25, 2022

No description provided.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

tremble
tremble previously requested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit this patch.

This RST file is automatically generated from the module as part of the release process. To avoid a regression the issue needs to be fixed there:

https://github.com/ansible-collections/amazon.aws/blob/main/plugins/inventory/aws_ec2.py#L21

Unfortunately, this actually looks like a bug in the tool we use to generate the RST. The best option may be to switch it to C(aws_ec2.{yml|yaml})

@AleksaC
Copy link
Contributor Author

AleksaC commented Jan 27, 2022

Oh, didn't see it was generated, sorry. Don't know which tool is used, but it might be intentional and maybe would work by escaping the closing paren. Either way {yml,yaml} is probably better anyway.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tremble
Copy link
Contributor

tremble commented Jan 27, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@ansibullbot ansibullbot added community_review inventory inventory plugin needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Jan 27, 2022
@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Feb 4, 2022
@alinabuzachis alinabuzachis requested a review from tremble February 4, 2022 15:10
@jillr jillr added gate and removed needs_triage labels Feb 8, 2022
@alinabuzachis alinabuzachis dismissed tremble’s stale review February 9, 2022 13:47

The author addressed the suggested changes.

@alinabuzachis alinabuzachis added mergeit Merge the PR (SoftwareFactory) and removed gate labels Feb 9, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4a0cd9d into ansible-collections:main Feb 9, 2022
@patchback
Copy link

patchback bot commented Feb 9, 2022 •
edited
Loading

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/4a0cd9d816e781d02fdf9302b1f29bd39ec935fb/pr-636

Backported as #658

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 9, 2022
@AleksaC @patchback
Replace (yml|yaml) with {yml,yaml} so it gets converted to rst correc…
1352787 
…tly (#636)

Fix typo

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
(cherry picked from commit 4a0cd9d)
@patchback patchback bot mentioned this pull request Feb 9, 2022
Merged
@patchback
Copy link

patchback bot commented Feb 9, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/4a0cd9d816e781d02fdf9302b1f29bd39ec935fb/pr-636

Backported as #660

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 9, 2022
@AleksaC @patchback
Replace (yml|yaml) with {yml,yaml} so it gets converted to rst correc…
894742f 
…tly (#636)

Fix typo

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
(cherry picked from commit 4a0cd9d)
@patchback patchback bot mentioned this pull request Feb 9, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 9, 2022
@patchback
Replace (yml|yaml) with {yml,yaml} so it gets converted to rst correc…
f71427e 
…tly (#636) (#660)

[PR #636/4a0cd9d8 backport][stable-3] Fix typo

This is a backport of PR #636 as merged into main (4a0cd9d).
None
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 22, 2022
@patchback
Replace (yml|yaml) with {yml,yaml} so it gets converted to rst correc…
5bc5599 
…tly (#636) (#658)

[PR #636/4a0cd9d8 backport][stable-2] Fix typo

This is a backport of PR #636 as merged into main (4a0cd9d).
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@jillr jillr jillr approved these changes

@tremble tremble Awaiting requested review from tremble

Assignees
No one assigned
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch community_review inventory inventory plugin mergeit Merge the PR (SoftwareFactory) new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AleksaC @tremble @alinabuzachis @jillr @ansibullbot