Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipv4, ipv6, ipsubnet have moved from ansible.netcommon to ansible.utils #635

Conversation

sebastien-rosset
Copy link
Contributor

@sebastien-rosset sebastien-rosset commented Jan 24, 2022

SUMMARY

This is a maintenance task to migrate from ansible.netcommon to ansible.utils. I was trying to fix an issue in that module, but I was told the functions have moved to ansible.utils. See ansible-collections/ansible.netcommon#362 (comment)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Existing integration tests that use the ansible.netcommon module. No module uses netcommon, only integration tests.

ADDITIONAL INFORMATION

@sebastien-rosset sebastien-rosset marked this pull request as ready for review January 24, 2022 20:57
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Jan 27, 2022
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastien-rosset Thank you for taking time to work on this. Could you please add a changelog fragment?

@alinabuzachis
Copy link
Collaborator

@tremble @jillr @markuman Do you thing we need to back port this to stable-2?

@markuman
Copy link
Member

markuman commented Feb 4, 2022

@tremble @jillr @markuman Do you thing we need to back port this to stable-2?

I don't know that ...

@jillr
Copy link
Collaborator

jillr commented Feb 8, 2022

@alinabuzachis yes we should backport it so CI is working for that branch, thanks!

@jillr jillr removed the needs_triage label Feb 8, 2022
@alinabuzachis alinabuzachis added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch mergeit Merge the PR (SoftwareFactory) labels Feb 9, 2022
@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0db6ac1 into ansible-collections:main Feb 9, 2022
@patchback
Copy link

patchback bot commented Feb 9, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/0db6ac1058ad698739dcaba1078eaedf7e9055f7/pr-635

Backported as #659

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 9, 2022
…ls (#635)

ipv4, ipv6, ipsubnet have moved from ansible.netcommon to ansible.utils

SUMMARY

This is a maintenance task to migrate from ansible.netcommon to ansible.utils. I was trying to fix an issue in that module, but I was told the functions have moved to ansible.utils. See ansible-collections/ansible.netcommon#362 (comment)

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

Existing integration tests that use the ansible.netcommon module. No module uses netcommon, only integration tests.
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 0db6ac1)
@patchback
Copy link

patchback bot commented Feb 9, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/0db6ac1058ad698739dcaba1078eaedf7e9055f7/pr-635

Backported as #661

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 9, 2022
…ls (#635)

ipv4, ipv6, ipsubnet have moved from ansible.netcommon to ansible.utils

SUMMARY

This is a maintenance task to migrate from ansible.netcommon to ansible.utils. I was trying to fix an issue in that module, but I was told the functions have moved to ansible.utils. See ansible-collections/ansible.netcommon#362 (comment)

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

Existing integration tests that use the ansible.netcommon module. No module uses netcommon, only integration tests.
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 0db6ac1)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 9, 2022
…ls (#635) (#661)

[PR #635/0db6ac10 backport][stable-3] ipv4, ipv6, ipsubnet have moved from ansible.netcommon to ansible.utils

This is a backport of PR #635 as merged into main (0db6ac1).
SUMMARY

This is a maintenance task to migrate from ansible.netcommon to ansible.utils. I was trying to fix an issue in that module, but I was told the functions have moved to ansible.utils. See ansible-collections/ansible.netcommon#362 (comment)

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

Existing integration tests that use the ansible.netcommon module. No module uses netcommon, only integration tests.
ADDITIONAL INFORMATION
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 9, 2022
…ls (#635) (#659)

[PR #635/0db6ac10 backport][stable-2] ipv4, ipv6, ipsubnet have moved from ansible.netcommon to ansible.utils

This is a backport of PR #635 as merged into main (0db6ac1).
SUMMARY

This is a maintenance task to migrate from ansible.netcommon to ansible.utils. I was trying to fix an issue in that module, but I was told the functions have moved to ansible.utils. See ansible-collections/ansible.netcommon#362 (comment)

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

Existing integration tests that use the ansible.netcommon module. No module uses netcommon, only integration tests.
ADDITIONAL INFORMATION
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…templates

Add Issue Templates/Forms

SUMMARY
We've had a number of issues posted recently without the templates. This results in maintainers needing to guess to fill in the blanks. Use forms rather than the default template to make it harder to skip things like examples.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
.github
ADDITIONAL INFORMATION
Based on ansible-collections#400 and ansible-collections#401

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants