ec2_vol - support changing from volume without IOPS to one with IOPS
#627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
markuman
reviewed
Jan 20, 2022
|
Build succeeded.
|
alinabuzachis
approved these changes
Jan 20, 2022
markuman
approved these changes
Jan 20, 2022
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
|
Thank you @markuman , @alinabuzachis , and @jillr for the quick attention. Could this get backported as well? |
|
recheck |
|
Build succeeded.
|
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #640 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
#627) `ec2_vol` - support changing from volume without IOPS to one with IOPS SUMMARY Fixes #626 Changing from standard volume type to gp3 failed when the module was trying to read the "original" IOPS value from the existing volume, since it doesn't have one. See the linked issue for detailed description. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION N/A Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> (cherry picked from commit a9b9bd1)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 9, 2022
#627) (#640) [PR #627/a9b9bd13 backport][stable-2] `ec2_vol` - support changing from volume without IOPS to one with IOPS This is a backport of PR #627 as merged into main (a9b9bd1). SUMMARY Fixes #626 Changing from standard volume type to gp3 failed when the module was trying to read the "original" IOPS value from the existing volume, since it doesn't have one. See the linked issue for detailed description. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION N/A Reviewed-by: Jill R <None>
|
@jillr could this go into stable-3 as well? |
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Feb 18, 2022
ansible-collections#627) (ansible-collections#640) [PR ansible-collections#627/a9b9bd13 backport][stable-2] `ec2_vol` - support changing from volume without IOPS to one with IOPS This is a backport of PR ansible-collections#627 as merged into main (a9b9bd1). SUMMARY Fixes ansible-collections#626 Changing from standard volume type to gp3 failed when the module was trying to read the "original" IOPS value from the existing volume, since it doesn't have one. See the linked issue for detailed description. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION N/A Reviewed-by: Jill R <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Feb 18, 2022
ansible-collections#627) `ec2_vol` - support changing from volume without IOPS to one with IOPS SUMMARY Fixes ansible-collections#626 Changing from standard volume type to gp3 failed when the module was trying to read the "original" IOPS value from the existing volume, since it doesn't have one. See the linked issue for detailed description. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION N/A Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 22, 2022
#627) (#687) ec2_vol - support changing from volume without IOPS to one with IOPS ec2_vol - support changing from volume without IOPS to one with IOPS Backport of PR #627 as merged into main (a9b9bd1) to stable-3 as well (it was originally only backported to stable-2). SUMMARY Fixes #626 Changing from standard volume type to gp3 failed when the module was trying to read the "original" IOPS value from the existing volume, since it doesn't have one. See the linked issue for detailed description. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION N/A Reviewed-by: Jill R SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Felix Fontein <[email protected]> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Add markuman as a collection maintainer to BOTMETA SUMMARY Add @markuman to BOTMETA.yml team_aws Fixes ansible-collections#627 ISSUE TYPE Feature Pull Request COMPONENT NAME BOTMETA.tml ADDITIONAL INFORMATION 2 maintainers have voted +1 in linked issue. Thanks for all your contributions @markuman, glad to have you aboard! Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #626
Changing from
standardvolume type togp3failed when the module was trying to read the "original" IOPS value from the existing volume, since it doesn't have one.See the linked issue for detailed description.
ISSUE TYPE
COMPONENT NAME
ec2_vol
ADDITIONAL INFORMATION
N/A