ec2_vol: Add support for OutpostArn param #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mandar242 Thank you for working on this. The main issue with AWS Outpost is that we cannot test it at the moment. I would suggest to kindly ask @hferreira23 for testing this feature if possible. |
This was referenced Dec 26, 2021
|
I'm on vacation right now :) Once I go back to the office (where I have access to an Outpost), I'll try this patch. |
|
@alinabuzachis @mandar242, sorry that took me a while but from what I could test it seems to work as we hope. I created the volume in the Outpost just fine. |
No problem! Thank you for testing it! |
jillr
reviewed
Jan 10, 2022
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
goneri
previously requested changes
Jan 12, 2022
tests/unit/module_utils/test_ec2.py
Outdated
| # ec2.is_outposts_arn | ||
| # ======================================================== | ||
|
|
||
| @parametrize( |
There was a problem hiding this comment.
Use @pytest.mark.parametrize instead.
There was a problem hiding this comment.
@goneri @pytest.mark.parametrize cannot be used with unittest.TestCase methods, for this reason Mandar used parametrize. He is trying to fix this by placing the test method outside of the class.
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Some pep8 errors to be addressed. @mandar242. Otherwise, this LGTM! |
|
Build failed.
|
|
Build succeeded.
|
alinabuzachis
approved these changes
Jan 17, 2022
jillr
approved these changes
Jan 24, 2022
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Add keys_attr parameter to aws_kms_info SUMMARY Move the kms_info return value from "keys" (which conflicts with keys()) to kms_keys. Add a parameter to support the old version Fixes ansible-collections#597 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_kms_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added support for
OutpostArnparam inec2_vol.Fixes #366.
ISSUE TYPE
COMPONENT NAME
ec2_vol