-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_secret: Handle pagination for bypath=true #591
aws_secret: Handle pagination for bypath=true #591
Conversation
Tested locally with
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recheck |
This comment has been minimized.
This comment has been minimized.
recheck |
This comment has been minimized.
This comment has been minimized.
recheck |
This comment has been minimized.
This comment has been minimized.
recheck |
This comment has been minimized.
This comment has been minimized.
recheck |
This comment has been minimized.
This comment has been minimized.
recheck |
1 similar comment
recheck |
This comment has been minimized.
This comment has been minimized.
recheck |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mandar242 Thank you. LGTM!
recheck |
This change depends on a change that failed to merge. |
recheck |
regate |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #693 🤖 @patchback |
aws_secret: Handle pagination for bypath=true Depends-On: ansible/ansible-zuul-jobs#1359 Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Currently aws_secret returns only 10 secrets, added manual pagination for getting all the secrets as per the task. Fixes #472. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 9f0a616)
[PR #591/9f0a616e backport][stable-3] aws_secret: Handle pagination for bypath=true This is a backport of PR #591 as merged into main (9f0a616). Depends-On: ansible/ansible-zuul-jobs#1359 Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Currently aws_secret returns only 10 secrets, added manual pagination for getting all the secrets as per the task. Fixes #472. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret
Depends-On: ansible/ansible-zuul-jobs#1359
Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY
Currently aws_secret returns only 10 secrets, added manual pagination for getting all the secrets as per the task.
Fixes #472.
ISSUE TYPE
COMPONENT NAME
aws_secret