Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_key - add support for tagging and returning id #548

Merged
merged 2 commits into from
Oct 25, 2021
Merged

ec2_key - add support for tagging and returning id #548

merged 2 commits into from
Oct 25, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 23, 2021

SUMMARY

Add support for tagging key pairs and also return the key ID

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_key

ADDITIONAL INFORMATION

fixes: #546
fixes: #547

@ansibullbot
Copy link

cc @jillr @prasadkatti @s-hertel @wimnat @zbal
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module module_utils module_utils needs_triage plugins plugin (any type) tests tests labels Oct 23, 2021
This was referenced Oct 23, 2021
Closed
Closed
@tremble tremble requested a review from alinabuzachis October 23, 2021 19:10
@andytson
Copy link

Thanks, I've tested this and it returns the id as expected and assigns the tags

@tremble tremble added the gate label Oct 25, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 8213151 into ansible-collections:main Oct 25, 2021
@tremble tremble deleted the tags/ec2_key branch November 26, 2021 12:41
@tremble tremble mentioned this pull request Oct 11, 2022
Closed
1 task
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@ansible-zuul
Merge pull request ansible-collections#548 from heytrav/elb-target-gr…
c87531f 
…oup-app-session

Collect arguments for application session stickiness and update docs

Reviewed-by: https://github.com/apps/ansible-zuul
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@ansible-zuul
Merge pull request ansible-collections#548 from heytrav/elb-target-gr…
0ac5175 
…oup-app-session

Collect arguments for application session stickiness and update docs

Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request has_issue integration tests/integration module_utils module_utils module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ec2_key: provide the ability to assign tags ec2_key: include KeyPairId in result
4 participants
@tremble @ansibullbot @andytson @alinabuzachis