Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_eni: Add check_mode support to ec2_eni #534

Merged
merged 7 commits into from
Oct 15, 2021
Merged

ec2_eni: Add check_mode support to ec2_eni #534

merged 7 commits into from
Oct 15, 2021

Conversation

mandar242
Copy link
Contributor

SUMMARY

Add check_mode support to ec2_eni.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_eni

@ansibullbot
Copy link

cc @healem @jillr @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Oct 14, 2021
tremble
tremble requested changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mandar,

Looks pretty good. I've had a quick look and have some initial feedback.

plugins/modules/ec2_eni.py Outdated Show resolved Hide resolved
plugins/modules/ec2_eni.py Outdated Show resolved Hide resolved
plugins/modules/ec2_eni.py Outdated Show resolved Hide resolved
plugins/modules/ec2_eni.py Outdated Show resolved Hide resolved
@mandar242 mandar242 requested a review from tremble October 15, 2021 08:34
@tremble
Copy link
Contributor

tremble commented Oct 15, 2021

recheck

@tremble tremble added the gate label Oct 15, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tremble tremble added gate and removed gate labels Oct 15, 2021
@ansible-zuul ansible-zuul bot merged commit 6a0194b into ansible-collections:main Oct 15, 2021
@mandar242 mandar242 deleted the ec2_eni_check_mode branch October 16, 2021 10:18
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@ansible-zuul
Merge pull request ansible-collections#534 from alinabuzachis/ec2_dep…
649fa50 
…ends_on

ecs_taskdefinition: Documentation improvement

Reviewed-by: https://github.com/apps/ansible-zuul
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@ansible-zuul
Merge pull request ansible-collections#534 from alinabuzachis/ec2_dep…
0b87626 
…ends_on

ecs_taskdefinition: Documentation improvement

Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandar242 @ansibullbot @tremble