Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use module_util helper for tagging AMIs #520

Merged
merged 5 commits into from
Oct 4, 2021
Merged

Use module_util helper for tagging AMIs #520

merged 5 commits into from
Oct 4, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 1, 2021

SUMMARY

We have some helpers for tagging EC2 resources, use them for tagging AMIs.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_ami

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @Constantin07 @gunzy83 @jillr @s-hertel @scicoin-project @wilvk @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Oct 1, 2021
@alinabuzachis
Copy link
Collaborator

alinabuzachis commented Oct 1, 2021 •
edited
Loading

@tremble Does this PR solve this issue #511 as well?

@tremble
Copy link
Contributor Author

tremble commented Oct 1, 2021

@alinabuzachis It does now, I should probably add an integration test though.

@alinabuzachis alinabuzachis linked an issue Oct 1, 2021 that may be closed by this pull request
EC2 AMI Creation/Tagging Fails #511
Closed
1 task
@ansibullbot ansibullbot added integration tests/integration tests tests and removed owner_pr PR created by owner/maintainer labels Oct 1, 2021
@tremble tremble mentioned this pull request Oct 2, 2021
Closed
1 task
alinabuzachis
alinabuzachis approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tremble tremble added the gate label Oct 4, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit b9f0bda into ansible-collections:main Oct 4, 2021
@tremble tremble deleted the tags/ec2_ami branch November 26, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@mandar242 mandar242 Awaiting requested review from mandar242

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request has_issue integration tests/integration module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EC2 AMI Creation/Tagging Fails
3 participants
@tremble @ansibullbot @alinabuzachis