Fix how CloudFormation stack changes are detected #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the times when there are no changes, the change set will have a status FAILED with StatusReason="The submitted information didn't contain changes. Submit different information to create a change set.", but sometimes StatusReason is "No updates are to be performed." when
ansibullbot
added
community_review
module
Fix errors from checks at https://dashboard.zuul.ansible.com/t/ansible/build/9e26ca58308747a8829cef60bd96189c * ERROR: plugins/modules/cloudformation.py:452:133: E271: multiple spaces after keyword * ERROR: plugins/modules/cloudformation.py:452:161: E501: line too long (193 > 160 characters)
|
@devt Thank you for taking time to work on this. Could you please include a changelog fragment https://cn-ansibledoc.readthedocs.io/zh_CN/latest/community/development_process.html#creating-a-changelog-fragment? |
Hopefully syntax above conforms to https://cn-ansibledoc.readthedocs.io/zh_CN/latest/community/development_process.html#creating-a-changelog-fragment
|
recheck |
1 similar comment
|
recheck |
tremble
approved these changes
Oct 6, 2021
tremble
reviewed
Oct 6, 2021
changelogs/fragments/507-fix_cloudformation_changeset_detection.yml
Outdated
Show resolved
Hide resolved
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the times when there are no changes, the change set will have a status FAILED with StatusReason="The submitted information didn't contain changes. Submit different information to create a change set.", but sometimes StatusReason is "No updates are to be performed."