Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for instance to start before attempting to attach a volume #497

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 11, 2021

SUMMARY

Following #481 ec2_vol tests failed because the instances hadn't finished starting before trying to attach

botocore.exceptions.ClientError: An error occurred (IncorrectState) when calling the AttachVolume operation: Instance 'i-0d740b81c23f11a4c' is not 'running'.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vol

ADDITIONAL INFORMATION

https://7860a9269d0955476c03-81788054a9528b940bcdbd064c8a3746.ssl.cf1.rackcdn.com/488/b02aebad5940f5500e4ccb93c093bc00339b2426/check/ansible-test-cloud-integration-aws-py36_1/110bed5/job-output.txt

```
botocore.exceptions.ClientError: An error occurred (IncorrectState) when calling the AttachVolume operation: Instance 'i-0d740b81c23f11a4c' is not 'running'.
```
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage plugins plugin (any type) python3 tests tests labels Sep 11, 2021
@tremble tremble added the gate label Sep 11, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tremble
Copy link
Contributor Author

tremble commented Sep 11, 2021

This is only to the tests and isn't a change to the ec2_vol part of the tests so I'm going to gate it.

@ansible-zuul ansible-zuul bot merged commit ada0fd9 into ansible-collections:main Sep 11, 2021
@tremble tremble deleted the ec2_vol/tests/instance_running branch November 26, 2021 12:42
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
* s3_sync - add support for choosing storage_class when objects are added to an S3 bucket.

Signed-off-by: Alina Buzachis <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
* s3_sync - add support for choosing storage_class when objects are added to an S3 bucket.

Signed-off-by: Alina Buzachis <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
* s3_sync - add support for choosing storage_class when objects are added to an S3 bucket.

Signed-off-by: Alina Buzachis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration needs_triage plugins plugin (any type) python3 tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants