Don't emit warning when VPC has IPv6 CIDR associated #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnmvisser
changed the title
ansibullbot
added
bug
|
While I agree that this is probably the right behaviour, the integration test needs updating to remove the check for this warning (tests/integration/targets/ec2_vpc_net) |
|
recheck |
tremble
approved these changes
Sep 9, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Run DMS integration tests in CI SUMMARY Tests are minimal, but they exercise the basic functions. retry ansible-collections#490 it's a little wonky due to CI moving about ISSUE TYPE Tests Pull Request COMPONENT NAME dms_endpoint dms_replication_subnet_group ADDITIONAL INFORMATION Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Setting
ipv6_cidr: yeson anec2_vpc_nettask will create a VPC with an associated IPv6 CIDR. Running the same task again will result in no changes as the VPC will already contain an IPv6 CIDR (i.e. idempotence).But the task will now raise a warning every time:
This warning is unnecessary because what happens is actually expected, i.e. "the right thing": idempotence.
So, the warning should be removed.
ISSUE TYPE
COMPONENT NAME
ec2_vpc_net