Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_spot_instance_info: add new module for describing spot instance requests #487

Merged
merged 24 commits into from
Sep 13, 2021
Merged

ec2_spot_instance_info: add new module for describing spot instance requests #487

merged 24 commits into from
Sep 13, 2021

Conversation

mandar242
Copy link
Contributor

SUMMARY

Added a new module that describes the specified Spot Instance requests.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ec2_spot_instance_info

ADDITIONAL INFORMATION
Related Documentation:
https://docs.aws.amazon.com/goto/WebAPI/ec2-2016-11-15/DescribeSpotInstanceRequests

@mandar242 mandar242 self-assigned this Sep 3, 2021
@mandar242 mandar242 changed the title ec2_spot_instance_info: add new module for describing spot instance requests [WIP] ec2_spot_instance_info: add new module for describing spot instance requests Sep 3, 2021
@ansibullbot
Copy link

@mandar242 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added WIP Work in progress merge_commit This PR contains at least one merge commit. Please resolve! module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html new_module New module new_plugin New plugin labels Sep 3, 2021
@mandar242 mandar242 force-pushed the module-ec2_spot_instance_info branch from a772752 to b0cf0a2 Compare September 7, 2021 18:38
@ansibullbot
Copy link

cc @jillr @s-hertel @srirachanaachyuthuni @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added integration tests/integration plugins plugin (any type) tests tests and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Sep 7, 2021
jillr
jillr reviewed Sep 7, 2021
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far @mandar242! A couple of comments about conventions that we usually use in the aws modules.

plugins/modules/ec2_spot_instance_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_spot_instance_info.py Outdated Show resolved Hide resolved
jillr
jillr reviewed Sep 9, 2021
View reviewed changes
plugins/modules/ec2_spot_instance_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_spot_instance_info.py Outdated Show resolved Hide resolved
tests/integration/targets/ec2_spot_instance/tasks/main.yaml Outdated Show resolved Hide resolved
tests/integration/targets/ec2_spot_instance/tasks/main.yaml Outdated Show resolved Hide resolved
@mandar242 mandar242 changed the title [WIP] ec2_spot_instance_info: add new module for describing spot instance requests ec2_spot_instance_info: add new module for describing spot instance requests Sep 10, 2021
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Sep 10, 2021
jillr
jillr approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for all your work on this @mandar242!

@jillr jillr added the gate label Sep 13, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jillr jillr added gate and removed gate labels Sep 13, 2021
@ansible-zuul ansible-zuul bot merged commit ccb1760 into ansible-collections:main Sep 13, 2021
@mandar242 mandar242 deleted the module-ec2_spot_instance_info branch September 17, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@jillr jillr jillr approved these changes

Assignees

@mandar242 mandar242

Labels
community_review integration tests/integration module module new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandar242 @ansibullbot @jillr