Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some integration tests for aws_service_ip_ranges #473

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Aug 27, 2021

SUMMARY

Add some integration tests for aws_service_ip_ranges

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_service_ip_ranges

ADDITIONAL INFORMATION

Initial tests to support #430

@tremble tremble requested review from alinabuzachis and jillr August 27, 2021 12:40
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration needs_triage tests tests labels Aug 27, 2021
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tremble Thank you. Do we need a changelog for this?

@tremble
Copy link
Contributor Author

tremble commented Aug 27, 2021

There's nothing consumer-facing, so no changelog is needed.

@tremble tremble added the gate label Aug 27, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 997a0ef into ansible-collections:main Aug 27, 2021
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Aug 28, 2021
* Stabilize and improve ec2_vpc_endpoint modules

- Add tagging support
- Make idempotent
- Better exception handling
- Better check_mode support
- Use module_utils for common functions
- Enable retries on common AWS failures

* Make endpoint deletion idempotent in check_mode

* Sanity fixes

* Address review feedback

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@f1d338d
@tremble tremble deleted the tests/aws_service_ip_ranges branch November 26, 2021 12:43
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
* Stabilize and improve ec2_vpc_endpoint modules

- Add tagging support
- Make idempotent
- Better exception handling
- Better check_mode support
- Use module_utils for common functions
- Enable retries on common AWS failures

* Make endpoint deletion idempotent in check_mode

* Sanity fixes

* Address review feedback
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
* Stabilize and improve ec2_vpc_endpoint modules

- Add tagging support
- Make idempotent
- Better exception handling
- Better check_mode support
- Use module_utils for common functions
- Enable retries on common AWS failures

* Make endpoint deletion idempotent in check_mode

* Sanity fixes

* Address review feedback
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
* Stabilize and improve ec2_vpc_endpoint modules

- Add tagging support
- Make idempotent
- Better exception handling
- Better check_mode support
- Use module_utils for common functions
- Enable retries on common AWS failures

* Make endpoint deletion idempotent in check_mode

* Sanity fixes

* Address review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration needs_triage tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants