Drop compile/import tests for old versions of python in sanity tests #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
|
ansible/ansible-zuul-jobs#1028 now limits the compile/import tests to Python 3.6 and 3.8, and drops the Python 3-ism boilerplate tests, which in turn means we can drop the swathes of "!skip" entries in the ignore files |
tremble
force-pushed
the
sanity/cleanup-skip
branch
2 times, most recently
from
ef26ce0 to
3fea402
Compare
alinabuzachis
approved these changes
Aug 10, 2021
|
@tremble That's a nice thing in my opinion. BTW, It seems to be an issue with the splitter. |
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
ansible-zuul bot
added a commit
to ansible-collections/community.aws
that referenced
this pull request
Aug 10, 2021
Drop compile/import tests for old versions of python in sanity tests SUMMARY We don't support Python < 3.6, so drop the tests at the Zuul job level rather than with a large number of !skip entries ISSUE TYPE Feature Pull Request COMPONENT NAME tests/sanity ADDITIONAL INFORMATION (see also ansible-collections/amazon.aws#447) Zuul change: ansible/ansible-zuul-jobs#1028 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
|
recheck |
…un, rather than lots of !skip lines
tremble
force-pushed
the
sanity/cleanup-skip
branch
from
3fea402 to
72e8405
Compare
…ther than resource_prefix
tremble
force-pushed
the
sanity/cleanup-skip
branch
from
72e8405 to
07d57e3
Compare
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
* Migrate s3_logging to boto3 * Re-enable s3_logging tests * Add support for check_mode * Catch and retry on "InvalidTargetBucketForLogging" - ACL updates occasionally take time to propogate * changelog
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
* Migrate s3_logging to boto3 * Re-enable s3_logging tests * Add support for check_mode * Catch and retry on "InvalidTargetBucketForLogging" - ACL updates occasionally take time to propogate * changelog
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
* Migrate s3_logging to boto3 * Re-enable s3_logging tests * Add support for check_mode * Catch and retry on "InvalidTargetBucketForLogging" - ACL updates occasionally take time to propogate * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We don't support Python < 3.6, so drop the tests at the Zuul job level rather than with a large number of !skip entries
ISSUE TYPE
COMPONENT NAME
sanity tests
ADDITIONAL INFORMATION
Depends-On: ansible/ansible-zuul-jobs#1028