Add new "require_boto(3|core)_at_least() helpers #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
force-pushed
the
boto3/require_at_least
branch
2 times, most recently
from
5bbaa4e to
8ca2372
Compare
tremble
force-pushed
the
boto3/require_at_least
branch
from
8ca2372 to
9ea0249
Compare
|
recheck |
alinabuzachis
approved these changes
Aug 9, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
ansible-zuul bot
added a commit
to ansible-collections/community.aws
that referenced
this pull request
Aug 10, 2021
Cleanup boto3/botocore dependencies - remove tests for unsupported versions SUMMARY Testing for boto3/botocore support on specific functions is very inconsistent. Now that we have minimum supported versions we can drop the tests for previous versions. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_eks_cluster.py plugins/modules/aws_msk_cluster.py plugins/modules/aws_msk_config.py plugins/modules/cloudformation_stack_set.py plugins/modules/dynamodb_table.py plugins/modules/dynamodb_ttl.py plugins/modules/ec2_ami_copy.py plugins/modules/ec2_asg.py plugins/modules/ec2_launch_template.py plugins/modules/ec2_transit_gateway.py plugins/modules/ec2_transit_gateway_info.py plugins/modules/ec2_vpc_peer.py plugins/modules/ecs_ecr.py plugins/modules/ecs_service.py plugins/modules/ecs_task.py plugins/modules/ecs_taskdefinition.py plugins/modules/efs.py plugins/modules/efs_info.py plugins/modules/elb_target_group.py plugins/modules/iam_role.py plugins/modules/lambda.py plugins/modules/rds_instance.py plugins/modules/sqs_queue.py ADDITIONAL INFORMATION Depends-on: ansible-collections/amazon.aws#442 Depends-on: ansible-collections/amazon.aws#446 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 12, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 13, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 13, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 13, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 13, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 13, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 13, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
that referenced
this pull request
Aug 25, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
that referenced
this pull request
Aug 25, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
that referenced
this pull request
Aug 26, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
that referenced
this pull request
Aug 26, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 26, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
jillr
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 27, 2021
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@52fb230
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Cleanup boto3/botocore dependencies - remove tests for unsupported versions SUMMARY Testing for boto3/botocore support on specific functions is very inconsistent. Now that we have minimum supported versions we can drop the tests for previous versions. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_eks_cluster.py plugins/modules/aws_msk_cluster.py plugins/modules/aws_msk_config.py plugins/modules/cloudformation_stack_set.py plugins/modules/dynamodb_table.py plugins/modules/dynamodb_ttl.py plugins/modules/ec2_ami_copy.py plugins/modules/ec2_asg.py plugins/modules/ec2_launch_template.py plugins/modules/ec2_transit_gateway.py plugins/modules/ec2_transit_gateway_info.py plugins/modules/ec2_vpc_peer.py plugins/modules/ecs_ecr.py plugins/modules/ecs_service.py plugins/modules/ecs_task.py plugins/modules/ecs_taskdefinition.py plugins/modules/efs.py plugins/modules/efs_info.py plugins/modules/elb_target_group.py plugins/modules/iam_role.py plugins/modules/lambda.py plugins/modules/rds_instance.py plugins/modules/sqs_queue.py ADDITIONAL INFORMATION Depends-on: ansible-collections#442 Depends-on: ansible-collections#446 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
* Solve RequestLimitExceeded error by adding the retry decorator Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We currently have lots of different ways we output that we needed a library, add a helper for our standard use-case of minimum botocore versions for a feature.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/core.py
plugins/modules/ec2_vol.py
ADDITIONAL INFORMATION