Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_ami - ensure tags are propagated to the snapshot(s) #437

Merged
merged 2 commits into from
Aug 19, 2021
Merged

ec2_ami - ensure tags are propagated to the snapshot(s) #437

merged 2 commits into from
Aug 19, 2021

Conversation

alinabuzachis
Copy link
Collaborator

@alinabuzachis alinabuzachis commented Aug 4, 2021 •
edited
Loading

SUMMARY

ec2_ami - ensure tags are propagated to the snapshot(s) when creating an AMI.

Fixes #368

Using --tag-specifications would introduce additional complexity for handling tags within the ec2_ami module. A simple approach would be to ensure tags propagation during AMI creation to the snapshot(s) and then edit snapshot(s) tags using the ec2_tag module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_ami

@ansibullbot
Copy link

cc @Constantin07 @gunzy83 @jillr @s-hertel @scicoin-project @tremble @wilvk @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Aug 4, 2021
@alinabuzachis
Copy link
Collaborator Author

recheck

1 similar comment
@alinabuzachis
Copy link
Collaborator Author

recheck

@jillr jillr added the gate label Aug 19, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 54e1f95 into ansible-collections:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag AMI Snapshots
4 participants
@alinabuzachis @ansibullbot @jillr @gravesm