-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark ec2_group and ec2_snapshot as slow tests #420
Conversation
recheck |
We need to either add more jobs, or increase the job and sts session timeouts. We've enabled a lot of new tests in the last year and even with the split we're running 17 tests in, for example, ansible-test-cloud-integration-aws-py36_6. Many of these are not slow.
We've got something like 263 total modules between the collections now, plus all the plugins. Scaling is hard. :) More jobs risks API request limit throttling, increased timeouts means longer jobs and longer feedback loops on PRs. Going to start with trying an additional job split as it's the simplest Zuul change and see how it goes. ETA: |
ec2_group seems to just be flaky? not helpful when it takes an hour to get to the point of flaking though. |
+1 ec2_group looks flakey, specifically on the dynamically created group test |
recheck |
ec2_group alternately succeeds, and fails at totally different places on my local machine. Flakes. |
recheck |
looks like ec2_group and ec2_snapshot are both flaking. |
recheck |
2 similar comments
recheck |
recheck |
As far as I can tell nothing ever sets the necessary var for this task to execute: And indeed the conditional is False.
I'm reading my way (albeit slowly) through the AWS Zuul config in its entirety trying to figure out what we ought to be doing. |
recheck |
2 similar comments
recheck |
recheck |
recheck |
1 similar comment
recheck |
recheck |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
recheck |
(rebased) |
recheck |
recheck |
…eger as duration (ansible-collections#420) * sts_assume_role: Relax expectations on message when passing a non-integer as duration * Use standard module_defaults block to pass credentials and switch to aws_caller_info * Delete the instance profile when we delete the role This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b3f5d45
…eger as duration (ansible-collections#420) * sts_assume_role: Relax expectations on message when passing a non-integer as duration * Use standard module_defaults block to pass credentials and switch to aws_caller_info * Delete the instance profile when we delete the role This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b3f5d45
…eger as duration (ansible-collections#420) * sts_assume_role: Relax expectations on message when passing a non-integer as duration * Use standard module_defaults block to pass credentials and switch to aws_caller_info * Delete the instance profile when we delete the role
SUMMARY
Mark these tests as slow so they get their own, dedicated job.
WIP as I'm (ab)using this PR to also fix a few other zuul things
ISSUE TYPE
COMPONENT NAME
ec2_group, ec2_snapshot
ADDITIONAL INFORMATION
From https://github.com/goneri/ci_analytics/blob/main/AWS_TIMEOUTS