Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ec2_group and ec2_snapshot as slow tests #420

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

jillr
Copy link
Collaborator

@jillr jillr commented Jul 27, 2021

SUMMARY

Mark these tests as slow so they get their own, dedicated job.

WIP as I'm (ab)using this PR to also fix a few other zuul things

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_group, ec2_snapshot

ADDITIONAL INFORMATION

From https://github.com/goneri/ci_analytics/blob/main/AWS_TIMEOUTS

ci_analytics$ ./AWS_TIMEOUTS 
Looking for AWS jobs that timeouted during the last 72 hours...
🧪 Log URL: https://2d83767e7d0b47cc6467-b552e5dea4fd4e73803214f8adfb6e6e.ssl.cf2.rackcdn.com/414/870c76561d3a91a74b84b7e079206d86ce981577/check/ansible-test-cloud-integration-aws-py36_2/22e2886//job-output.txt
  🎯 ec2_snapshot lasted 1708 seconds, from 02:12:33 to 02:41:02.
 ⌛ All the targets took 0:50:33.111938 to run.
🧪 Log URL: https://34667caf4980e1a898ee-75746687dfc2ac5ed97d146b7085c3b2.ssl.cf5.rackcdn.com/414/900aab708871f9517b57a777400715b76d755879/check/ansible-test-cloud-integration-aws-py36_2/a271b16//job-output.txt
  🎯 ec2_snapshot lasted 1541 seconds, from 00:54:47 to 01:20:29.
 ⌛ All the targets took 0:47:48.584199 to run.
🧪 Log URL: https://437dd30aa6615d2ae5b6-0c148146fa0d08a9a2fa172bb9668f3c.ssl.cf1.rackcdn.com/414/900aab708871f9517b57a777400715b76d755879/check/ansible-test-cloud-integration-aws-py36_2/e12c53e//job-output.txt
 ⌛ All the targets took 0:30:30.997345 to run.
🧪 Log URL: https://45e6dee77ce59d98994f-3af13d43dd38bc19ce7c59853caeabda.ssl.cf2.rackcdn.com/418/8e6e37a8e9b873ec40bd46db7df55953c111cac2/check/ansible-test-cloud-integration-aws-py36_2/57b7a59//job-output.txt
  🎯 ec2_group lasted 1241 seconds, from 20:36:20 to 20:57:01.
 ⌛ All the targets took 0:39:32.194628 to run.

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage plugins plugin (any type) python3 small_patch Hopefully easy to review tests tests labels Jul 27, 2021
@ansibullbot
Copy link

cc @lwade
click here for bot help

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jul 27, 2021
@ansibullbot
Copy link

@tremble
Copy link
Contributor

tremble commented Jul 28, 2021

recheck

@jillr
Copy link
Collaborator Author

jillr commented Jul 28, 2021

We need to either add more jobs, or increase the job and sts session timeouts. We've enabled a lot of new tests in the last year and even with the split we're running 17 tests in, for example, ansible-test-cloud-integration-aws-py36_6. Many of these are not slow.

2021-07-28 11:44:44.909197 | About to run: ansible-test integration --diff --no-temp-workdir --skip-tags False --retry-on-error --continue-on-error --python 3.6 -vvvv cloudformation ec2_key ec2_vpc_dhcp_option module_utils_core s3_bucket module_utils_ec2 module_utils_waiter ec2_tag lookup_aws_account_attribute ec2_elb_lb aws_caller_info aws_az_info ec2 inventory_aws_ec2 aws_s3 lookup_aws_secret ec2_metadata_facts ec2_vpc_net

We've got something like 263 total modules between the collections now, plus all the plugins. Scaling is hard. :)

More jobs risks API request limit throttling, increased timeouts means longer jobs and longer feedback loops on PRs. Going to start with trying an additional job split as it's the simplest Zuul change and see how it goes.

ETA: also --diff doesn't seem to be having an effect? I confused --diff with --changed.

@jillr
Copy link
Collaborator Author

jillr commented Jul 28, 2021

ec2_group seems to just be flaky? not helpful when it takes an hour to get to the point of flaking though.

@tremble
Copy link
Contributor

tremble commented Jul 28, 2021

+1 ec2_group looks flakey, specifically on the dynamically created group test

@jillr
Copy link
Collaborator Author

jillr commented Jul 28, 2021

recheck

@jillr
Copy link
Collaborator Author

jillr commented Jul 28, 2021

ec2_group alternately succeeds, and fails at totally different places on my local machine. Flakes.

@tremble
Copy link
Contributor

tremble commented Jul 28, 2021

recheck

@jillr
Copy link
Collaborator Author

jillr commented Jul 28, 2021

looks like ec2_group and ec2_snapshot are both flaking.

@jillr
Copy link
Collaborator Author

jillr commented Jul 28, 2021

recheck

2 similar comments
@jillr
Copy link
Collaborator Author

jillr commented Jul 28, 2021

recheck

@jillr
Copy link
Collaborator Author

jillr commented Jul 29, 2021

recheck

@jillr
Copy link
Collaborator Author

jillr commented Jul 29, 2021

As far as I can tell nothing ever sets the necessary var for this task to execute:
https://github.com/ansible/ansible-zuul-jobs/blob/master/roles/ansible-test-splitter/tasks/main.yaml#L4

And indeed the conditional is False.

2021-07-29 22:54:17.896606 | PLAY [controller]
2021-07-29 22:54:17.942431 | 
2021-07-29 22:54:17.942612 | TASK [ansible-test-splitter : copy]
2021-07-29 22:54:18.035965 | fedora-34 | skipping: Conditional result was False
2021-07-29 22:54:18.086002 | 
2021-07-29 22:54:18.086124 | TASK [ansible-test-splitter : Identify the changed targets]
2021-07-29 22:54:18.202013 | fedora-34 | skipping: Conditional result was False
2021-07-29 22:54:18.236949 | 
2021-07-29 22:54:18.237066 | TASK [ansible-test-splitter : set_fact]
2021-07-29 22:54:18.321551 | fedora-34 | skipping: Conditional result was False

I'm reading my way (albeit slowly) through the AWS Zuul config in its entirety trying to figure out what we ought to be doing.

@jillr
Copy link
Collaborator Author

jillr commented Jul 30, 2021

recheck

2 similar comments
@jillr
Copy link
Collaborator Author

jillr commented Jul 30, 2021

recheck

@jillr
Copy link
Collaborator Author

jillr commented Jul 30, 2021

recheck

@jillr jillr changed the title Mark ec2_group and ec2_snapshot as slow tests [WIP] Mark ec2_group and ec2_snapshot as slow tests Jul 30, 2021
@ansibullbot ansibullbot added the WIP Work in progress label Jul 30, 2021
@jillr
Copy link
Collaborator Author

jillr commented Jul 31, 2021

recheck

1 similar comment
@jillr
Copy link
Collaborator Author

jillr commented Jul 31, 2021

recheck

@jillr jillr changed the title [WIP] Mark ec2_group and ec2_snapshot as slow tests Mark ec2_group and ec2_snapshot as slow tests Aug 2, 2021
@jillr
Copy link
Collaborator Author

jillr commented Aug 2, 2021

recheck

@ansibullbot ansibullbot added shipit and removed WIP Work in progress community_review labels Aug 2, 2021
@jillr
Copy link
Collaborator Author

jillr commented Aug 3, 2021

recheck

@jillr jillr added the gate label Aug 3, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jillr
Copy link
Collaborator Author

jillr commented Aug 4, 2021

recheck

@tremble
Copy link
Contributor

tremble commented Aug 5, 2021

(rebased)

@tremble
Copy link
Contributor

tremble commented Aug 5, 2021

recheck

@tremble tremble added the gate label Aug 5, 2021
@tremble
Copy link
Contributor

tremble commented Aug 6, 2021

recheck

@ansible-zuul ansible-zuul bot merged commit 1f74a39 into ansible-collections:main Aug 6, 2021
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Sep 28, 2023
…eger as duration (ansible-collections#420)

* sts_assume_role: Relax expectations on message when passing a non-integer as duration

* Use standard module_defaults block to pass credentials and switch to aws_caller_info

* Delete the instance profile when we delete the role

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@b3f5d45
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 6, 2023
…eger as duration (ansible-collections#420)

* sts_assume_role: Relax expectations on message when passing a non-integer as duration

* Use standard module_defaults block to pass credentials and switch to aws_caller_info

* Delete the instance profile when we delete the role

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@b3f5d45
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…eger as duration (ansible-collections#420)

* sts_assume_role: Relax expectations on message when passing a non-integer as duration

* Use standard module_defaults block to pass credentials and switch to aws_caller_info

* Delete the instance profile when we delete the role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug has_issue integration tests/integration plugins plugin (any type) python3 tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants