Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3_bucket - handle "NotImplemented" for encryption #391

Merged
merged 5 commits into from
Jun 30, 2021
Merged

s3_bucket - handle "NotImplemented" for encryption #391

merged 5 commits into from
Jun 30, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 21, 2021

SUMMARY

fixes: #390

DigitalOcean doesn't support the encryption settings (and returns a NotImplemented error).

Additionally:

  • Slight logic tweak to avoid the line-too-long linting error
  • Avoid importing specific exceptions for consistency with other modules
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

s3_bucket

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @abikouo @jillr @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jun 21, 2021
@tremble tremble force-pushed the s3_bucket/enc_notimplemented branch from c428dc3 to 19a8b7c Compare June 21, 2021 09:11
alinabuzachis
alinabuzachis approved these changes Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @tremble.

@tremble tremble added the gate label Jun 30, 2021
@ansible-zuul ansible-zuul bot merged commit 34d6bc9 into ansible-collections:main Jun 30, 2021
@tremble tremble mentioned this pull request Sep 9, 2021
Closed
1 task
@tremble tremble deleted the s3_bucket/enc_notimplemented branch November 26, 2021 12:42
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
Move community.aws tests from ec2 to ec2_instance (ansible-collection…
48d1b48 
…s#391)

* Move tests from ec2 to ec2_instance
* Make sure we wait for instances to go away
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review module module owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

s3_bucket -- DigitialOcean Spaces compatibility
4 participants
@tremble @ansibullbot @alinabuzachis @gravesm