Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use head_bucket vs list_buckets to determine if s3 bucket exists #357

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Use head_bucket vs list_buckets to determine if s3 bucket exists #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bbb3df
use head_bucket request to determine if s3 bucket exists
May 4, 2021
dc81e8b
use is_boto3_error_code rather than directly reading response['Error'…
tremble Aug 27, 2021
1125b2c
changelog
tremble Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/357-s3_bucket-use-head.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- s3_bucket - updated to use HeadBucket instead of ListBucket when testing for bucket existence (https://github.com/ansible-collections/amazon.aws/pull/357).
10 changes: 6 additions & 4 deletions plugins/modules/s3_bucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,10 +509,12 @@ def create_or_update_bucket(s3_client, module, location):


def bucket_exists(s3_client, bucket_name):
# head_bucket appeared to be really inconsistent, so we use list_buckets instead,
# and loop over all the buckets, even if we know it's less performant :(
all_buckets = s3_client.list_buckets(Bucket=bucket_name)['Buckets']
return any(bucket['Name'] == bucket_name for bucket in all_buckets)
try:
s3_client.head_bucket(Bucket=bucket_name)
bucket_exists = True
except is_boto3_error_code('404'):
bucket_exists = False
return bucket_exists


@AWSRetry.exponential_backoff(max_delay=120)
Expand Down