Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudformation: use is_boto3_error_message #355

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 4, 2021

SUMMARY

use our is_boto3_error_message helper to handle 'expected' failures

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cloudformation

ADDITIONAL INFORMATION

Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when the syntax errors are fixed

plugins/modules/cloudformation.py Outdated Show resolved Hide resolved
plugins/modules/cloudformation.py Outdated Show resolved Hide resolved
@tremble tremble force-pushed the cloudformation/is_boto3_error_code branch from 95a8340 to 8504170 Compare May 5, 2021 04:40
@tremble tremble force-pushed the cloudformation/is_boto3_error_code branch from 8504170 to 0f9a9e8 Compare May 15, 2021 11:40
@tremble
Copy link
Contributor Author

tremble commented May 19, 2021

recheck

@jillr jillr added the gate label May 20, 2021
@ansible-zuul ansible-zuul bot merged commit 0164b48 into ansible-collections:main May 20, 2021
@tremble tremble deleted the cloudformation/is_boto3_error_code branch May 28, 2021 07:07
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@2276333
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
-- 129 --
See: ansible-collections/community.aws@faa7d64
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 16, 2021
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 16, 2024
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
…nsible-collections#355)

* Return all infos of a VPC peering connection in ec2_vpc_peer module.
* More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@faa7d64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants