-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudformation: use is_boto3_error_message #355
Merged
ansible-zuul
merged 3 commits into
ansible-collections:main
from
tremble:cloudformation/is_boto3_error_code
May 20, 2021
Merged
Cloudformation: use is_boto3_error_message #355
ansible-zuul
merged 3 commits into
ansible-collections:main
from
tremble:cloudformation/is_boto3_error_code
May 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillr
approved these changes
May 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm when the syntax errors are fixed
tremble
force-pushed
the
cloudformation/is_boto3_error_code
branch
from
May 5, 2021 04:40
95a8340
to
8504170
Compare
tremble
force-pushed
the
cloudformation/is_boto3_error_code
branch
from
May 15, 2021 11:40
8504170
to
0f9a9e8
Compare
recheck |
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2276333
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws -- 129 -- See: ansible-collections/community.aws@faa7d64
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 16, 2021
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 11, 2024
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 11, 2024
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 11, 2024
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 11, 2024
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 11, 2024
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 11, 2024
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 11, 2024
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 16, 2024
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 24, 2024
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 24, 2024
…nsible-collections#355) * Return all infos of a VPC peering connection in ec2_vpc_peer module. * More extensive tests for vpc_peer module. Also got rid of redundant helper method in vpc_peer module This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@faa7d64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
use our is_boto3_error_message helper to handle 'expected' failures
ISSUE TYPE
COMPONENT NAME
cloudformation
ADDITIONAL INFORMATION