Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws_s3] Assign keyrtn var before use #339

Merged
merged 1 commit into from
Apr 26, 2021
Merged

[aws_s3] Assign keyrtn var before use #339

merged 1 commit into from
Apr 26, 2021

Conversation

jillr
Copy link
Collaborator

@jillr jillr commented Apr 23, 2021 •
edited by goneri
Loading

Depends-On: #340

SUMMARY

keyrtn in put mode is only assigned if bucketrtn is not empty/False, but is later checked on any put task.

Fixes: #338

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_s3

@jillr
[aws_s3] Assign keyrtn var before use
563e20d 
keyrtn in `put` mode is only assigned if bucketrtn is not empty/False,
but is later checked on any `put` task.

Fixes: 338
@ansibullbot
Copy link

cc @lwade @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review labels Apr 23, 2021
tremble
tremble requested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        "bucket_name": "ansible-test-65998209-centos-8-1vcpu-limestone-us-slc-000137110.bucket"

Looks like the new Zuul resource_prefix is too long for the aws_s3 tests. We'll need something shorter before this passes gating

@goneri
Copy link
Member

goneri commented Apr 26, 2021

I will take a look at this prefix length issue. We've got the same issue with the CI with #311.

@goneri
Copy link
Member

goneri commented Apr 26, 2021

recheck

1 similar comment
@goneri
Copy link
Member

goneri commented Apr 26, 2021

recheck

@goneri goneri added the gate label Apr 26, 2021
@ansible-zuul ansible-zuul bot merged commit 96c3fad into ansible-collections:main Apr 26, 2021
@jillr jillr deleted the aws_s3_var_assignment branch July 2, 2021 22:47
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble
ec2_metric_alarm - tweak example to be more generic (ansible-collecti…
02794a9 
…ons#339)

* ec2_metric_alarm - Update docs to remove reference to slave

We don't need to specifically talk about bamboo, and they now use 'agent'

* Tweak import order in line with PEP-0008
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble @abikouo
ec2_metric_alarm - tweak example to be more generic (ansible-collecti…
9d3f94a 
…ons#339)

* ec2_metric_alarm - Update docs to remove reference to slave

We don't need to specifically talk about bamboo, and they now use 'agent'

* Tweak import order in line with PEP-0008
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
ec2_metric_alarm - tweak example to be more generic (ansible-collecti…
e088eda 
…ons#339)

* ec2_metric_alarm - Update docs to remove reference to slave

We don't need to specifically talk about bamboo, and they now use 'agent'

* Tweak import order in line with PEP-0008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble requested changes

@abikouo abikouo abikouo approved these changes

@goneri goneri goneri approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws_s3] Local variable unassigned CI errors
5 participants
@jillr @ansibullbot @goneri @tremble @abikouo