Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address pylint errors #280

Closed

Conversation

goneri
Copy link
Member

@goneri goneri commented Mar 4, 2021

This commit addresses the three following pylint errors:

  • plugins/module_utils/cloud.py:145:27: isinstance-second-argument-not-valid-type: Second argument of isinstance is not a type
  • plugins/module_utils/cloudfront_facts.py:166:0: unnecessary-comprehension: Unnecessary use of a comprehension
  • plugins/module_utils/core.py:192:4: property-with-parameters: Cannot have defined parameters for properties

This commit addresses the three following pylint errors:

- plugins/module_utils/cloud.py:145:27: isinstance-second-argument-not-valid-type: Second argument of isinstance is not a type
- plugins/module_utils/cloudfront_facts.py:166:0: unnecessary-comprehension: Unnecessary use of a comprehension
- plugins/module_utils/core.py:192:4: property-with-parameters: Cannot have defined parameters for properties
@goneri
Copy link
Member Author

goneri commented Mar 4, 2021

Merged in #278

@goneri goneri closed this Mar 4, 2021
@tremble tremble mentioned this pull request Mar 5, 2021
tremble added a commit to tremble/amazon.aws that referenced this pull request Mar 5, 2021
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
…ansible-collections#280)

* Use botocore_at_least rather than LooseVersion/StrictVersion directly

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
-- 250 --
See: ansible-collections/community.aws@46102ff
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 16, 2021
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ansible-collections#280)

* Use botocore_at_least rather than LooseVersion/StrictVersion directly

* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ansible-collections#280)

* Use botocore_at_least rather than LooseVersion/StrictVersion directly

* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ansible-collections#280)

* Use botocore_at_least rather than LooseVersion/StrictVersion directly

* changelog
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 16, 2024
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants