Remove deprecated boto3 parameter #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
boto/final_cleanup
branch
from
eeddf2a to
70f8ba0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
abikouo
approved these changes
Jan 10, 2025
tremble
added
mergeit
|
regate |
tremble
force-pushed
the
boto/final_cleanup
branch
from
70f8ba0 to
802c923
Compare
tremble
added
mergeit
alinabuzachis
approved these changes
Jan 13, 2025
|
regate |
softwarefactory-project-zuul
bot
merged commit 9ae20ab
into
ansible-collections:main
44 of 46 checks passed
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jan 15, 2025
SUMMARY Since we dropped support for the old boto SDK (ansible-collections#630) the boto3 parameter for get_aws_region() and get_aws_connection_info() has done nothing. This finally removes the parameter (deprecated ansible-collections#2047) ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jan 15, 2025
SUMMARY Since we dropped support for the old boto SDK (ansible-collections#630) the boto3 parameter for get_aws_region() and get_aws_connection_info() has done nothing. This finally removes the parameter (deprecated ansible-collections#2047) ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Since we dropped support for the old boto SDK (#630) the
boto3parameter forget_aws_region()andget_aws_connection_info()has done nothing. This finally removes the parameter (deprecated #2047)ISSUE TYPE
COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION