Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds_cluster - fix issue when updating rds cluster domain #2401

Merged
merged 1 commit into from
Dec 9, 2024
Merged

rds_cluster - fix issue when updating rds cluster domain #2401

merged 1 commit into from
Dec 9, 2024

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Nov 28, 2024

SUMMARY

Closes #2390
Fix issue when trying to update RDS cluster with new domain
add unit tests to validate the fix

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds_cluster

@abikouo abikouo mentioned this pull request Nov 28, 2024
Closed
1 task
@abikouo abikouo force-pushed the rds_cluster_issue_2390 branch from 2f85178 to ef878a4 Compare November 28, 2024 17:08
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a70b4cf455ed47d48b73f81b19ffb211

✔️ ansible-galaxy-importer SUCCESS in 5m 13s
✔️ build-ansible-collection SUCCESS in 10m 48s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-amazon.aws-1 SUCCESS in 34m 11s
✔️ integration-amazon.aws-2 SUCCESS in 10m 18s
✔️ integration-amazon.aws-3 SUCCESS in 8m 19s
✔️ integration-amazon.aws-4 SUCCESS in 10m 20s
✔️ integration-amazon.aws-5 SUCCESS in 18m 39s
✔️ integration-amazon.aws-6 SUCCESS in 7m 08s
Skipped 38 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Dec 9, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/cea529c29248456db225c51dc6504311

✔️ ansible-galaxy-importer SUCCESS in 8m 08s
✔️ build-ansible-collection SUCCESS in 10m 35s
✔️ ansible-test-splitter SUCCESS in 4m 09s
✔️ integration-amazon.aws-1 SUCCESS in 35m 32s
✔️ integration-amazon.aws-2 SUCCESS in 9m 48s
✔️ integration-amazon.aws-3 SUCCESS in 6m 40s
✔️ integration-amazon.aws-4 SUCCESS in 11m 40s
✔️ integration-amazon.aws-5 SUCCESS in 15m 27s
✔️ integration-amazon.aws-6 SUCCESS in 8m 19s
Skipped 38 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit da0027d into ansible-collections:main Dec 9, 2024
46 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 9, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/da0027dddd31251c896c1af1f589769e20b332d8/pr-2401

Backported as #2419

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 9, 2024
@abikouo @patchback
rds_cluster - fix issue when updating rds cluster domain (#2401)
089430d 
SUMMARY

Closes #2390
Fix issue when trying to update RDS cluster with new domain
add unit tests to validate the fix

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

rds_cluster

Reviewed-by: Alina Buzachis
(cherry picked from commit da0027d)
@patchback patchback bot mentioned this pull request Dec 9, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 9, 2024
@patchback
rds_cluster - fix issue when updating rds cluster domain (#2401) (#2419)
d8088b0 
This is a backport of PR #2401 as merged into main (da0027d).
SUMMARY

Closes #2390
Fix issue when trying to update RDS cluster with new domain
add unit tests to validate the fix

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

rds_cluster

Reviewed-by: Bikouo Aubin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@tremble tremble Awaiting requested review from tremble

@hakbailey hakbailey Awaiting requested review from hakbailey

@GomathiselviS GomathiselviS Awaiting requested review from GomathiselviS

Assignees
No one assigned
Labels
backport-9 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws.rds_cluster usage of "domain" parameter fails due to "KeyError: 'Domain'"
2 participants
@abikouo @alinabuzachis